Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 19 Dec 2011 22:09:32 +0000 (UTC)
From: "Phabricator (Commented) (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <1957375920.28344.1324332572802.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <820139008.21657.1319673212155.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-4683) Always cache index and bloom blocks
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-4683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172667#comment-13172667 ] 

Phabricator commented on HBASE-4683:
------------------------------------

mbautin has abandoned the revision "[jira] [HBASE-4683] Always cache index and bloom blocks".
Added CCs: nspiegelberg, stack, tedyu

  @jdcryans: you committed this one, right?  Closing the Phabricator revision.

  A reminder to committers (quoting @nspiegelberg) so that we can properly close Phabricator revisions when committed (cc: @tedyu, @stack).

  >    since we've decided to allow more Metadata in our commit logs, it would be nice to use the patch comments when committing this diff. Namely, including 'Differential Revision: #' will allow Phabricator to automatically mark the review as closed.

  Here are the steps to set up Arcanist and Phabricator in your working directory so you can auto-generate the commit message:

  * mvn -Darc initialize
  * arc amend --revision <revision_number>

  You can install Arcanist (arc) by following the instructions at http://www.phabricator.com/docs/phabricator/article/Arcanist_User_Guide.html. More instructions about Phabricator/JIRA integration are available at https://cwiki.apache.org/confluence/display/Hive/PhabricatorCodeReview (that is a howto for Hive but it should be very similar for HBase).


REVISION DETAIL
  https://reviews.facebook.net/D807

                
> Always cache index and bloom blocks
> -----------------------------------
>
>                 Key: HBASE-4683
>                 URL: https://issues.apache.org/jira/browse/HBASE-4683
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Lars Hofhansl
>            Assignee: Mikhail Bautin
>            Priority: Minor
>             Fix For: 0.92.0, 0.94.0
>
>         Attachments: 0001-Cache-important-block-types.patch, 4683-v2.txt, 4683.txt, D807.1.patch, D807.2.patch, D807.3.patch, HBASE-4683-0.92-v2.patch, HBASE-4683-v3.patch
>
>
> This would add a new boolean config option: hfile.block.cache.datablocks
> Default would be true.
> Setting this to false allows HBase in a mode where only index blocks are cached, which is useful for analytical scenarios where a useful working set of the data cannot be expected to fit into the (aggregate) cache.
> This is the equivalent of setting cacheBlocks to false on all scans (including scans on behalf of gets).
> I would like to get a general feeling about what folks think about this.
> The change itself would be simple.
> Update (Mikhail): we probably don't need a new conf option. Instead, we will make index blocks cached by default.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira