Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7CE9C7BD2 for ; Wed, 7 Dec 2011 21:11:02 +0000 (UTC) Received: (qmail 23401 invoked by uid 500); 7 Dec 2011 21:11:02 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 23379 invoked by uid 500); 7 Dec 2011 21:11:02 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 23371 invoked by uid 99); 7 Dec 2011 21:11:02 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Dec 2011 21:11:02 +0000 X-ASF-Spam-Status: No, hits=-2001.2 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Dec 2011 21:11:01 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 3B851106156 for ; Wed, 7 Dec 2011 21:10:41 +0000 (UTC) Date: Wed, 7 Dec 2011 21:10:41 +0000 (UTC) From: "Ted Yu (Commented) (JIRA)" To: issues@hbase.apache.org Message-ID: <1835493616.50770.1323292241245.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <878065803.32182.1322770239930.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HBASE-4927) CatalogJanior:SplitParentFirstComparator doesn't sort as expected, for the last region when the endkey is empty MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-4927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164699#comment-13164699 ] Ted Yu commented on HBASE-4927: ------------------------------- Also ran through the two tests in original patch: {code} 1302 mt -Dtest=TestHRegionInfo 1303 mt -Dtest=TestCatalogJanitor {code} They passed as well. Integrated to 0.92 and TRUNK. Thanks for the addendum, Jimmy. Thanks for the help, Jonathan. > CatalogJanior:SplitParentFirstComparator doesn't sort as expected, for the last region when the endkey is empty > --------------------------------------------------------------------------------------------------------------- > > Key: HBASE-4927 > URL: https://issues.apache.org/jira/browse/HBASE-4927 > Project: HBase > Issue Type: Bug > Components: master > Affects Versions: 0.92.0, 0.94.0 > Reporter: Jimmy Xiang > Assignee: Jimmy Xiang > Priority: Minor > Fix For: 0.92.0 > > Attachments: 0001-Fixed-TestOffline-failure-caused-by-HBASE-4927.patch, 0001-Fixed-TestOffline-failure-caused-by-HBASE-4927.patch, 0001-HBASE-4927-CatalogJanior-SplitParentFirstComparator-.patch, 0001-HBASE-4927-CatalogJanior-SplitParentFirstComparator_v2.patch, hbase-4927-fix-ws.txt > > > When reviewing HBASE-4238 backporting, Jon found this issue. > What happens if the split points are (empty end key is the last key, empty start key is the first key) > Parent [A,) > L daughter [A,B), > R daughter [B,) > When sorted, we gets to end key comparision which results in this incorrector order: > [A,B), [A,), [B,) > we wanted: > [A,), [A,B), [B,) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira