Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 8 Dec 2011 04:11:40 +0000 (UTC)
From: "chunhui shen (Commented) (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <1686035668.52271.1323317500445.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <353325440.16206.1322457519964.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-4880) Region is on service before
 openRegionHandler completes, may cause data loss
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-4880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164973#comment-13164973 ] 

chunhui shen commented on HBASE-4880:
-------------------------------------

@ram
I think so.
It is not needed in cleanupFailedOpen() for the current openRegionHanlder transaction
                
> Region is on service before openRegionHandler completes, may cause data loss
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-4880
>                 URL: https://issues.apache.org/jira/browse/HBASE-4880
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0, 0.94.0
>            Reporter: chunhui shen
>            Assignee: chunhui shen
>         Attachments: 4880.txt, hbase-4880.patch, hbase-4880v2.patch, hbase-4880v3.patch
>
>
> OpenRegionHandler in regionserver is processed as the following steps:
> {code}
> 1.openregion()(Through it, closed = false, closing = false)
> 2.addToOnlineRegions(region)
> 3.update .meta. table 
> 4.update ZK's node state to RS_ZK_REGION_OPEND
> {code}
> We can find that region is on service before Step 4.
> It means client could put data to this region after step 3.
> What will happen if step 4 is failed processing?
> It will execute OpenRegionHandler#cleanupFailedOpen which will do closing region, and master assign this region to another regionserver.
> If closing region is failed, the data which is put between step 3 and step 4 may loss, because the region has been opend on another regionserver and be put new data. Therefore, it may not be recoverd through replayRecoveredEdit() because the edit's LogSeqId is smaller than current region SeqId.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira