Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6E56A71CD for ; Fri, 9 Dec 2011 15:41:02 +0000 (UTC) Received: (qmail 39510 invoked by uid 500); 9 Dec 2011 15:41:02 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 39439 invoked by uid 500); 9 Dec 2011 15:41:02 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 39423 invoked by uid 99); 9 Dec 2011 15:41:02 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Dec 2011 15:41:02 +0000 X-ASF-Spam-Status: No, hits=-2001.2 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Dec 2011 15:41:00 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 51587109696 for ; Fri, 9 Dec 2011 15:40:40 +0000 (UTC) Date: Fri, 9 Dec 2011 15:40:40 +0000 (UTC) From: "Hudson (Commented) (JIRA)" To: issues@hbase.apache.org Message-ID: <1535111585.58657.1323445240334.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <2093628773.47900.1323221680047.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HBASE-4969) tautology in HRegionInfo.readFields MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-4969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166250#comment-13166250 ] Hudson commented on HBASE-4969: ------------------------------- Integrated in HBase-0.92 #180 (See [https://builds.apache.org/job/HBase-0.92/180/]) HBASE-4969 tautology in HRegionInfo.readFields stack : Files : * /hbase/branches/0.92/CHANGES.txt * /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java > tautology in HRegionInfo.readFields > ----------------------------------- > > Key: HBASE-4969 > URL: https://issues.apache.org/jira/browse/HBASE-4969 > Project: HBase > Issue Type: Bug > Reporter: Prakash Khemani > Assignee: Prakash Khemani > Fix For: 0.92.0 > > Attachments: HBASE-4969.D669.1.patch > > > In HRegionInfo.readFields() the following looks wrong to me > } else if (getVersion() == VERSION) { > it is always true. > Should it have been > } else if (getVersion() == version) { > version is a local variable where the deserialized-version is stored. > (I am struggling with another issue where after applying some patches - including "HBASE-4388 Second start after migration from 90 to trunk crashes" my version of hbase-92 HRegionInfo.readFields() tries to find HTD in HRegionInfo and fails) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira