Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 26 Dec 2011 21:42:30 +0000 (UTC)
From: "Lars Hofhansl (Commented) (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <1506301636.45596.1324935750703.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1718066800.45521.1324929990653.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-5096) Replication does not handle deletes
 correctly.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-5096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176020#comment-13176020 ] 

Lars Hofhansl commented on HBASE-5096:
--------------------------------------

Scary to think that this has gone unnoticed all this time.
                
> Replication does not handle deletes correctly.
> ----------------------------------------------
>
>                 Key: HBASE-5096
>                 URL: https://issues.apache.org/jira/browse/HBASE-5096
>             Project: HBase
>          Issue Type: Sub-task
>          Components: replication
>    Affects Versions: 0.94.0, 0.92.1
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>         Attachments: 5096.txt
>
>
> Teruyoshi Zenmyo discovered this problem.
> The problem turns out to be this code in ReplicationSink.java:
> {code}
> if (kvs.get(0).isDelete()) {
> ...
>   if (kv.isDeleteFamily()) {
>     delete.deleteFamily(kv.getFamily());
>   } else if (!kv.isEmptyColumn()) {
>     delete.deleteColumn(kv.getFamily(), kv.getQualifier());
>   }
> }
> ...
> {code}
> So the code deal with families delete markers and then assumes that if it's not a family delete marker it must have been a version delete marker.
> (deleteColumn sets a version delete marker, deleteColumns sets a column delete marker).
> I.e. column delete markers are not replicated correctly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira