Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 7 Dec 2011 20:48:39 +0000 (UTC)
From: "Jonathan Hsieh (Commented) (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <1387319320.50677.1323290919942.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <878065803.32182.1322770239930.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-4927)
 CatalogJanior:SplitParentFirstComparator doesn't sort as expected, for the
 last region when the endkey is empty
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-4927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164686#comment-13164686 ] 

Jonathan Hsieh commented on HBASE-4927:
---------------------------------------

Verison initially committed with this patch made the HRegionInfo's comparator declare  region ['','') smaller  ['', 'A').  Previously it was the other way around.  

In the TestOfflineMeta* tests, disableTable call eventually calls AssignmentManager#getRegionsOfTable(table).  This returns 3 regions instead of 4.  This is because this uses a "boundary" region with has [startkey='', endkey='').  The change likely left either the begin or end region out with this call.

The core problem is because the definintion of greater than or less than regions is inconsistent wrt to '' start and end keys.   

                
> CatalogJanior:SplitParentFirstComparator doesn't sort as expected, for the last region when the endkey is empty
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4927
>                 URL: https://issues.apache.org/jira/browse/HBASE-4927
>             Project: HBase
>          Issue Type: Bug
>          Components: master
>    Affects Versions: 0.92.0, 0.94.0
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>             Fix For: 0.92.0
>
>         Attachments: 0001-Fixed-TestOffline-failure-caused-by-HBASE-4927.patch, 0001-Fixed-TestOffline-failure-caused-by-HBASE-4927.patch, 0001-HBASE-4927-CatalogJanior-SplitParentFirstComparator-.patch, 0001-HBASE-4927-CatalogJanior-SplitParentFirstComparator_v2.patch, hbase-4927-fix-ws.txt
>
>
> When reviewing HBASE-4238 backporting, Jon found this issue.
> What happens if the split points are  (empty end key is the last key, empty start key is the first key)
> Parent     [A,)
> L daughter [A,B), 
> R daughter [B,)
> When sorted, we gets to end key comparision which results in this incorrector order:
> [A,B), [A,), [B,) 
> we wanted:
> [A,), [A,B), [B,)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira