Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 87988780E for ; Thu, 1 Dec 2011 04:00:07 +0000 (UTC) Received: (qmail 66642 invoked by uid 500); 1 Dec 2011 04:00:07 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 66299 invoked by uid 500); 1 Dec 2011 04:00:05 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 66245 invoked by uid 99); 1 Dec 2011 04:00:03 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Dec 2011 04:00:03 +0000 X-ASF-Spam-Status: No, hits=-2001.2 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Dec 2011 04:00:00 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id E39EFAA116 for ; Thu, 1 Dec 2011 03:59:39 +0000 (UTC) Date: Thu, 1 Dec 2011 03:59:39 +0000 (UTC) From: "stack (Commented) (JIRA)" To: issues@hbase.apache.org Message-ID: <133079219.29621.1322711979933.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1456572369.28626.1322696980531.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HBASE-4918) HTablePool Constructor may cause unintended behavior MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HBASE-4918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160633#comment-13160633 ] stack commented on HBASE-4918: ------------------------------ Yeah, thats wrong. It should be calling through to this constructor: {code} public HTablePool(final Configuration config, final int maxSize, final HTableInterfaceFactory tableFactory, PoolType poolType) { {code} Any chance of a patch Naoki? > HTablePool Constructor may cause unintended behavior > ---------------------------------------------------- > > Key: HBASE-4918 > URL: https://issues.apache.org/jira/browse/HBASE-4918 > Project: HBase > Issue Type: Bug > Components: client > Environment: r1125533 > Reporter: Kitora, Naoki > > {code:title=HTablePool.java} > 96 public HTablePool(final Configuration config, final int maxSize, > 97 final HTableInterfaceFactory tableFactory) { > 98 this(config, maxSize, null, PoolType.Reusable); > 99 } > {code} > I think that 3rd argument in line 98 should be "tableFactory". -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira