Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 27 Dec 2011 06:28:30 +0000 (UTC)
From: "Hudson (Commented) (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <1217724193.46034.1324967310746.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1718066800.45521.1324929990653.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-5096) Replication does not handle deletes
 correctly.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-5096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176101#comment-13176101 ] 

Hudson commented on HBASE-5096:
-------------------------------

Integrated in HBase-0.92 #210 (See [https://builds.apache.org/job/HBase-0.92/210/])
    HBASE-5096  Replication does not handle deletes correctly. (Lars H)

larsh : 
Files : 
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/replication/TestReplication.java

                
> Replication does not handle deletes correctly.
> ----------------------------------------------
>
>                 Key: HBASE-5096
>                 URL: https://issues.apache.org/jira/browse/HBASE-5096
>             Project: HBase
>          Issue Type: Sub-task
>          Components: replication
>    Affects Versions: 0.94.0, 0.92.1
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>             Fix For: 0.94.0, 0.92.1
>
>         Attachments: 5096.txt
>
>
> Teruyoshi Zenmyo discovered this problem.
> The problem turns out to be this code in ReplicationSink.java:
> {code}
> if (kvs.get(0).isDelete()) {
> ...
>   if (kv.isDeleteFamily()) {
>     delete.deleteFamily(kv.getFamily());
>   } else if (!kv.isEmptyColumn()) {
>     delete.deleteColumn(kv.getFamily(), kv.getQualifier());
>   }
> }
> ...
> {code}
> So the code deal with families delete markers and then assumes that if it's not a family delete marker it must have been a version delete marker.
> (deleteColumn sets a version delete marker, deleteColumns sets a column delete marker).
> I.e. column delete markers are not replicated correctly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira