Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 13 Dec 2011 23:37:30 +0000 (UTC)
From: "jiraposter@reviews.apache.org (Commented) (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <1039158359.8396.1323819450948.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1913944790.23522.1322605420080.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-4895) Change tablename format in meta to
 be the UUID of the tablename rather than the tablename.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168872#comment-13168872 ] 

jiraposter@reviews.apache.org commented on HBASE-4895:
------------------------------------------------------


bq.  On 2011-12-13 23:06:02, Michael Stack wrote:
bq.  > When I scan, I'll see uuids.  How do I go from uuid to tablename as I ask in below?

You can do it by getting the last hri for that table , and getting it's tablename. So it would require a meta hit. Expect an update soon


bq.  On 2011-12-13 23:06:02, Michael Stack wrote:
bq.  > src/main/java/org/apache/hadoop/hbase/HRegionInfo.java, line 347
bq.  > <https://reviews.apache.org/r/3188/diff/2/?file=64456#file64456line347>
bq.  >
bq.  >     This uuid type 3 will be same no matter what machine or time (it looks like it but asking if you verified)
bq.  >     
bq.  >     One day we should add to Bytes a Bytes.toBytes that takes a uuid

Verified


bq.  On 2011-12-13 23:06:02, Michael Stack wrote:
bq.  > src/main/java/org/apache/hadoop/hbase/HRegionInfo.java, line 391
bq.  > <https://reviews.apache.org/r/3188/diff/2/?file=64456#file64456line391>
bq.  >
bq.  >     Whats this here?  UUID tablename?

correct


bq.  On 2011-12-13 23:06:02, Michael Stack wrote:
bq.  > src/main/java/org/apache/hadoop/hbase/HRegionInfo.java, line 417
bq.  > <https://reviews.apache.org/r/3188/diff/2/?file=64456#file64456line417>
bq.  >
bq.  >     Is this tablename or uuid?  Don't you have to deprecate the old method rather than just drop it?

It is no longer possible to go from just a regionName to a tablename without a meta hit. I could implement the metahit?


bq.  On 2011-12-13 23:06:02, Michael Stack wrote:
bq.  > src/main/java/org/apache/hadoop/hbase/HRegionInfo.java, line 450
bq.  > <https://reviews.apache.org/r/3188/diff/2/?file=64456#file64456line450>
bq.  >
bq.  >     How do I go from uuid of tablename back to tablename?  I don't see it.

You can't without a meta hit.


bq.  On 2011-12-13 23:06:02, Michael Stack wrote:
bq.  > src/main/java/org/apache/hadoop/hbase/client/MetaSearchRow.java, line 50
bq.  > <https://reviews.apache.org/r/3188/diff/2/?file=64458#file64458line50>
bq.  >
bq.  >     Whats going on here?  The other patch adds this file.  So it has to go in first?

Correct, these three reviews are tied in a certain order. They could be combined into one patch to work, but they are easier to review on their own imho. I'd be glad to combine like the first review.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3188/#review3892
-----------------------------------------------------------


On 2011-12-13 21:13:46, Alex Newman wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3188/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-12-13 21:13:46)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  PART 2 of hbase-4616
bq.  
bq.  By uuiding the tablename in the metarow, it enables us to be able to use binary values for the end of table marker
bq.  
bq.  
bq.  This addresses bug HBASE-4895.
bq.      https://issues.apache.org/jira/browse/HBASE-4895
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    src/main/java/org/apache/hadoop/hbase/HRegionInfo.java 74cb821 
bq.    src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java e5e60a8 
bq.    src/main/java/org/apache/hadoop/hbase/client/MetaSearchRow.java PRE-CREATION 
bq.    src/main/java/org/apache/hadoop/hbase/util/Merge.java 67d0fda 
bq.    src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java 95712dd 
bq.    src/test/java/org/apache/hadoop/hbase/coprocessor/SampleRegionWALObserver.java ff9c502 
bq.    src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java 368a0e5 
bq.    src/test/java/org/apache/hadoop/hbase/coprocessor/TestWALObserver.java 36dd289 
bq.    src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java 6e1211b 
bq.    src/test/java/org/apache/hadoop/hbase/rest/TestStatusResource.java cffdcb6 
bq.    src/test/ruby/hbase/admin_test.rb 0c2672b 
bq.  
bq.  Diff: https://reviews.apache.org/r/3188/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Alex
bq.  
bq.


> Change tablename format in meta to be the UUID of the tablename rather than the tablename.
> ------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4895
>                 URL: https://issues.apache.org/jira/browse/HBASE-4895
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Alex Newman
>            Assignee: Alex Newman
>         Attachments: 0002-Moved-to-a-uuid-tablename.patch
>
>
> This is something stack and I discussed at hadoop world. Overall I think it cleans thing up significantly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira