Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 30 Dec 2011 00:57:31 +0000 (UTC)
From: "ramkrishna.s.vasudevan (Updated) (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <102720659.52921.1325206651155.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <812160085.46038.1324968150675.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Updated] (HBASE-5097) RegionObserver implementation whose
 preScannerOpen and postScannerOpen Impl return null can stall the system
 initialization through NPE
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HBASE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ramkrishna.s.vasudevan updated HBASE-5097:
------------------------------------------

    Attachment: HBASE-5097.patch

Trunk patch
                
> RegionObserver implementation whose preScannerOpen and postScannerOpen Impl return null can stall the system initialization through NPE
> ---------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5097
>                 URL: https://issues.apache.org/jira/browse/HBASE-5097
>             Project: HBase
>          Issue Type: Bug
>          Components: coprocessors
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>         Attachments: HBASE-5097.patch
>
>
> In HRegionServer.java openScanner()
> {code}
>       r.prepareScanner(scan);
>       RegionScanner s = null;
>       if (r.getCoprocessorHost() != null) {
>         s = r.getCoprocessorHost().preScannerOpen(scan);
>       }
>       if (s == null) {
>         s = r.getScanner(scan);
>       }
>       if (r.getCoprocessorHost() != null) {
>         s = r.getCoprocessorHost().postScannerOpen(scan, s);
>       }
> {code}
> If we dont have implemention for postScannerOpen the RegionScanner is null and so throwing nullpointer 
> {code}
> java.lang.NullPointerException
> 	at java.util.concurrent.ConcurrentHashMap.put(ConcurrentHashMap.java:881)
> 	at org.apache.hadoop.hbase.regionserver.HRegionServer.addScanner(HRegionServer.java:2282)
> 	at org.apache.hadoop.hbase.regionserver.HRegionServer.openScanner(HRegionServer.java:2272)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> 	at java.lang.reflect.Method.invoke(Method.java:597)
> 	at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Server.call(WritableRpcEngine.java:364)
> 	at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1326)
> {code}
> Making this defect as blocker.. Pls feel free to change the priority if am wrong.  Also correct me if my way of trying out coprocessors without implementing postScannerOpen is wrong.  Am just a learner.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira