hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4927) CatalogJanior:SplitParentFirstComparator doesn't sort as expected, for the last region when the endkey is empty
Date Mon, 05 Dec 2011 20:12:41 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162998#comment-13162998
] 

jiraposter@reviews.apache.org commented on HBASE-4927:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2992/
-----------------------------------------------------------

(Updated 2011-12-05 20:10:53.260565)


Review request for hbase and Michael Stack.


Changes
-------

Updated it per Ted's comment.


Summary
-------

Some HRegionInfo related comparator doesn't consider empty end key.  That's why there are
some hacks in HRegionInfo's containsRange and containsRow method to check empty key.
However, due to this issue, SplitParentFirstComparator has a bug.


This addresses bug HBASE-4927.
    https://issues.apache.org/jira/browse/HBASE-4927


Diffs (updated)
-----

  src/main/java/org/apache/hadoop/hbase/HRegionInfo.java 2a24d0b 
  src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java b356b22 
  src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java e047e30 
  src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java baca241 

Diff: https://reviews.apache.org/r/2992/diff


Testing
-------

TestHRegionInfo and TestCatalogJanitor are geen.


Thanks,

Jimmy


                
> CatalogJanior:SplitParentFirstComparator doesn't sort as expected, for the last region
when the endkey is empty
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4927
>                 URL: https://issues.apache.org/jira/browse/HBASE-4927
>             Project: HBase
>          Issue Type: Bug
>          Components: master
>    Affects Versions: 0.92.0, 0.94.0
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>             Fix For: 0.94.0
>
>         Attachments: 0001-HBASE-4927-CatalogJanior-SplitParentFirstComparator-.patch
>
>
> When reviewing HBASE-4238 backporting, Jon found this issue.
> What happens if the split points are  (empty end key is the last key, empty start key
is the first key)
> Parent     [A,)
> L daughter [A,B), 
> R daughter [B,)
> When sorted, we gets to end key comparision which results in this incorrector order:
> [A,B), [A,), [B,) 
> we wanted:
> [A,), [A,B), [B,)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message