hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5009) Failure of creating split dir if it already exists prevents splits from happening further
Date Fri, 16 Dec 2011 12:24:30 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13170933#comment-13170933
] 

ramkrishna.s.vasudevan commented on HBASE-5009:
-----------------------------------------------

The threadPool.awaitTermination() will ensure that the background thread pool is completed.
 
Also FSUtils.create() was doing an exists check and then createNewFile().  It was followed
by create().  Changed it to fs.create(p, false).  If the path had existed it will throw exception.
Pls review
                
> Failure of creating split dir if it already exists prevents splits from happening further
> -----------------------------------------------------------------------------------------
>
>                 Key: HBASE-5009
>                 URL: https://issues.apache.org/jira/browse/HBASE-5009
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.6
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>         Attachments: HBASE-5009.patch, HBASE-5009_Branch90.patch
>
>
> The scenario is
> -> The split of a region takes a long time
> -> The deletion of the splitDir fails due to HDFS problems.
> -> Subsequent splits also fail after that.
> {code}
> private static void createSplitDir(final FileSystem fs, final Path splitdir)
>   throws IOException {
>     if (fs.exists(splitdir)) throw new IOException("Splitdir already exits? " + splitdir);
>     if (!fs.mkdirs(splitdir)) throw new IOException("Failed create of " + splitdir);
>   }
> {code}
> Correct me if am wrong? If it is an issue can we change the behaviour of throwing exception?
> Pls suggest.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message