hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Hofhansl (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5058) Allow HBaseAmin to use an existing connection
Date Sat, 17 Dec 2011 07:05:31 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171481#comment-13171481
] 

Lars Hofhansl commented on HBASE-5058:
--------------------------------------

Thanks for reviewing stack.

Re UndeclaredThrowableException. HBaseAdmin used to catch it, but it should have never leaked
up to HBaseAdmin. According to the documentation it is "Thrown by a method invocation on a
proxy instance...". I verified experimentally that this exception is indeed thrown when I
shutdown the cluster and try to reuse the HConnection (or before the HBaseAdmin) instance.
Maybe that is another bug.

The 2nd part, yeah I think that was just dumb before. There are two levels of retrying. HConnection
already has a retry mechanism. That said, it seems that for unmanaged connections (i.e. created
by HBaseAdmin itself) the HConnectionManager.HConnectionImplementation.masterChecked would
not reset to false. I was thinking about just removing that flag, and that in fact might be
a better option. Then every call to HConnection.getMaster would try again, which is as it
should be. Let me make a new patch with this.


                
> Allow HBaseAmin to use an existing connection
> ---------------------------------------------
>
>                 Key: HBASE-5058
>                 URL: https://issues.apache.org/jira/browse/HBASE-5058
>             Project: HBase
>          Issue Type: Sub-task
>          Components: client
>    Affects Versions: 0.94.0
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>            Priority: Minor
>             Fix For: 0.94.0
>
>         Attachments: 5058.txt
>
>
> What HBASE-4805 does for HTables, this should do for HBaseAdmin.
> Along with this the shared error handling and retrying between HBaseAdmin and HConnectionManager
can also be improved. I'll attach a first pass patch soon.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message