hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5029) TestDistributedLogSplitting fails on occasion
Date Mon, 19 Dec 2011 22:57:30 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172707#comment-13172707
] 

stack commented on HBASE-5029:
------------------------------

Something like this:

{code}
diff --git src/main/java/org/apache/hadoop/hbase/regionserver/wal/SequenceFileLogWriter.java
src/main/java/org/apache/hadoop/hbase/regionserver/wal/SequenceFileLogWriter.java
index a3eb32f..cbef70f 100644
--- src/main/java/org/apache/hadoop/hbase/regionserver/wal/SequenceFileLogWriter.java
+++ src/main/java/org/apache/hadoop/hbase/regionserver/wal/SequenceFileLogWriter.java
@@ -211,7 +211,12 @@ public class SequenceFileLogWriter implements HLog.Writer {
   @Override
   public void close() throws IOException {
     if (this.writer != null) {
-      this.writer.close();
+      try {
+        this.writer.close();
+      } catch (NullPointerException npe) {
+        // Can get a NPE coming up from down in DFSClient$DFSOutputStream#close
+        LOG.warn(npe);
+      }
       this.writer = null;
     }
   }
{code}

I could commit above along w/ removal of the '@Ignore' to see how it does up on jenkins?
                
> TestDistributedLogSplitting fails on occasion
> ---------------------------------------------
>
>                 Key: HBASE-5029
>                 URL: https://issues.apache.org/jira/browse/HBASE-5029
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>            Assignee: Prakash Khemani
>            Priority: Critical
>         Attachments: 0001-HBASE-5029-jira-TestDistributedLogSplitting-fails-on.patch,
5029-addingignore.txt, HBASE-5029.D891.1.patch, HBASE-5029.D891.2.patch
>
>
> This is how it usually fails: https://builds.apache.org/view/G-L/view/HBase/job/HBase-0.92/lastCompletedBuild/testReport/org.apache.hadoop.hbase.master/TestDistributedLogSplitting/testWorkerAbort/
> Assigning mighty Prakash since he offered to take a looksee.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message