hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4605) Constraints
Date Mon, 05 Dec 2011 02:27:40 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162565#comment-13162565

Ted Yu commented on HBASE-4605:

Thanks Gary for the detailed review.
For the check() API:
  public void check(Put p) throws ConstraintException;
We can abstract the input parameter as Mutation.

I think we need to reach agreement on the following major issues:
1. introduction of dependency of Guava in client library - Jonathan Gray would strongly disagree
with this practice.
2. whether IntegerConstraint should be included in the constraint package
3. constraint configuration serialization method

If the current implementation for some of the above isn't critical to this feature (#1 and
#2), we can defer to future JIRAs.

Actually a fourth issue (raised by Suraj under the discussion of 'Question on Coprocessors
and Atomicity') is more important: if we don't provide atomicity by holding rowlock during
the check, the use cases for Constraints would decrease.
Issue #4 definitely doesn't have to be covered by this JIRA.

The fifth issue is how IntegrationTestConstraint.java should be tagged.
> Constraints
> -----------
>                 Key: HBASE-4605
>                 URL: https://issues.apache.org/jira/browse/HBASE-4605
>             Project: HBase
>          Issue Type: Improvement
>          Components: client, coprocessors
>    Affects Versions: 0.94.0
>            Reporter: Jesse Yates
>            Assignee: Jesse Yates
>         Attachments: 4605.v7, constraint_as_cp.txt, java_Constraint_v2.patch, java_HBASE-4605_v1.patch,
java_HBASE-4605_v2.patch, java_HBASE-4605_v3.patch
> From Jesse's comment on dev:
> {quote}
> What I would like to propose is a simple interface that people can use to implement a
'constraint' (matching the classic database definition). This would help ease of adoption
by helping HBase more easily check that box, help minimize code duplication across organizations,
and lead to easier adoption.
> Essentially, people would implement a 'Constraint' interface for checking keys before
they are put into a table. Puts that are valid get written to the table, but if not people
can will throw an exception that gets propagated back to the client explaining why the put
was invalid.
> Constraints would be set on a per-table basis and the user would be expected to ensure
the jars containing the constraint are present on the machines serving that table.
> Yes, people could roll their own mechanism for doing this via coprocessors each time,
but this would make it easier to do so, so you only have to implement a very minimal interface
and not worry about the specifics.
> {quote}

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message