hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4895) Change tablename format in meta to be the UUID of the tablename rather than the tablename.
Date Tue, 20 Dec 2011 00:49:32 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172798#comment-13172798
] 

jiraposter@reviews.apache.org commented on HBASE-4895:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3188/#review3992
-----------------------------------------------------------


I probably shouldn't be reviewing this again?


src/main/java/org/apache/hadoop/hbase/HRegionInfo.java
<https://reviews.apache.org/r/3188/#comment9044>

    If this is an md5 under the wraps, maybe we should just do md5 rather than do this uuid
indirection?  But maybe the UUID class has some facility you like that makes it easier to
work with?



src/main/java/org/apache/hadoop/hbase/HRegionInfo.java
<https://reviews.apache.org/r/3188/#comment9039>

    Why line here?



src/main/java/org/apache/hadoop/hbase/HRegionInfo.java
<https://reviews.apache.org/r/3188/#comment9040>

    Were we talking about uuids in original code?
    
    Should we cache tablename in HRI if we are passed it so can avoid a meta hit if absent?
    
    If a meta hit to get table name, its in the last HRI only?  Is that the plan?   The last
HRI in a table has the table name?  Or if not this, where is it in the meta table?



src/main/java/org/apache/hadoop/hbase/HRegionInfo.java
<https://reviews.apache.org/r/3188/#comment9041>

    Whats UUID tablename?  And though its not you, whats the 1|2 about?



src/main/java/org/apache/hadoop/hbase/HRegionInfo.java
<https://reviews.apache.org/r/3188/#comment9042>

    Something is wrong w/ this patch ?  We had a '@return The UUID of the Table name' in original
src?



src/main/java/org/apache/hadoop/hbase/client/MetaSearchRow.java
<https://reviews.apache.org/r/3188/#comment9043>

    MetaSearchRow is not in src, its brought in by another related patch?  So this is a patch
on top of that patch?


- Michael


On 2011-12-13 23:36:44, Alex Newman wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3188/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-12-13 23:36:44)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  PART 2 of hbase-4616
bq.  
bq.  By uuiding the tablename in the metarow, it enables us to be able to use binary values
for the end of table marker
bq.  
bq.  
bq.  This addresses bug HBASE-4895.
bq.      https://issues.apache.org/jira/browse/HBASE-4895
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    src/main/java/org/apache/hadoop/hbase/HRegionInfo.java 74cb821 
bq.    src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java e5e60a8 
bq.    src/main/java/org/apache/hadoop/hbase/client/MetaSearchRow.java PRE-CREATION 
bq.    src/main/java/org/apache/hadoop/hbase/util/Merge.java 67d0fda 
bq.    src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java 95712dd 
bq.    src/test/java/org/apache/hadoop/hbase/coprocessor/SampleRegionWALObserver.java ff9c502

bq.    src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java 368a0e5 
bq.    src/test/java/org/apache/hadoop/hbase/coprocessor/TestWALObserver.java 36dd289 
bq.    src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java 6e1211b 
bq.    src/test/java/org/apache/hadoop/hbase/rest/TestStatusResource.java cffdcb6 
bq.    src/test/ruby/hbase/admin_test.rb 0c2672b 
bq.  
bq.  Diff: https://reviews.apache.org/r/3188/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Alex
bq.  
bq.


                
> Change tablename format in meta to be the UUID of the tablename rather than the tablename.
> ------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4895
>                 URL: https://issues.apache.org/jira/browse/HBASE-4895
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Alex Newman
>            Assignee: Alex Newman
>         Attachments: 0002-Moved-to-a-uuid-tablename.patch
>
>
> This is something stack and I discussed at hadoop world. Overall I think it cleans thing
up significantly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message