hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4683) Always cache index and bloom blocks
Date Tue, 13 Dec 2011 23:53:30 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168888#comment-13168888
] 

stack commented on HBASE-4683:
------------------------------

The below...

{code}
+    boolean shouldCache = isBlockCacheEnabled()
+        && (cacheDataOnRead ||
+            category == BlockCategory.INDEX ||
+            category == BlockCategory.BLOOM);
+    return shouldCache;
{code}

should just be:

{code}
return isBlockCacheEnabled() &&
  (cacheDataOnRead ||
    category == BlockCategory.INDEX ||
    category == BlockCategory.BLOOM);
{code}

No need of intermediary local var.   But no biggie...

Is this SchemaConfigured stuff in 0.92 branch?

Unused imports in TestHRegion?

Otherwise patch looks ok to me.  Is it enough?

                
> Always cache index and bloom blocks
> -----------------------------------
>
>                 Key: HBASE-4683
>                 URL: https://issues.apache.org/jira/browse/HBASE-4683
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Lars Hofhansl
>            Assignee: Mikhail Bautin
>            Priority: Minor
>             Fix For: 0.92.0, 0.94.0
>
>         Attachments: 4683-v2.txt, 4683.txt, D807.1.patch, D807.2.patch, HBASE-4683-v3.patch
>
>
> This would add a new boolean config option: hfile.block.cache.datablocks
> Default would be true.
> Setting this to false allows HBase in a mode where only index blocks are cached, which
is useful for analytical scenarios where a useful working set of the data cannot be expected
to fit into the (aggregate) cache.
> This is the equivalent of setting cacheBlocks to false on all scans (including scans
on behalf of gets).
> I would like to get a general feeling about what folks think about this.
> The change itself would be simple.
> Update (Mikhail): we probably don't need a new conf option. Instead, we will make index
blocks cached by default.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message