hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5070) Constraints implementation and javadoc changes
Date Wed, 21 Dec 2011 19:29:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174339#comment-13174339
] 

jiraposter@reviews.apache.org commented on HBASE-5070:
------------------------------------------------------



bq.  On 2011-12-21 06:09:56, Michael Stack wrote:
bq.  > This patch should go in.  Good improvements.  Doesn't address the bigger issues
of Configuration inline w/ HTD -- have you tried it, I mean, IIRC, though you might have one
custom config only, the whole Configuration will be output per Constraint? -- and adding support
to shell.  Those are in different issues?

I'm going to try checking out the conf stuff for the Constraints today in the shell. Keep
in mind that the conf stored per Constraint should just be configuration info for the Constraint,
as opposed to the entire hbase conf (so we don't see all the values from hbase-site.xml, etc),
but by default only see the enabled and priority configuration values. I'm expecting that
to be pretty small, but I'll let you know.

Also, there is HBASE-4879 to add shell support to Constraints as the original was already
pretty massive (and taking a while) and the shell stuff could be cleanly separated out. I
was working on it, but have temporarily diverted from it to work on the maven modularization
(4336) as per Ted's request.


- Jesse


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3273/#review4034
-----------------------------------------------------------


On 2011-12-20 19:14:46, Jesse Yates wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3273/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-12-20 19:14:46)
bq.  
bq.  
bq.  Review request for hbase, Gary Helmling, Ted Yu, and Michael Stack.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Follow-up on changes to constraint as per stack's comments on HBASE-4605.
bq.  
bq.  
bq.  This addresses bug HBASE-5070.
bq.      https://issues.apache.org/jira/browse/HBASE-5070
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    src/docbkx/book.xml bd3f881 
bq.    src/main/java/org/apache/hadoop/hbase/constraint/BaseConstraint.java 7ce6d45 
bq.    src/main/java/org/apache/hadoop/hbase/constraint/Constraint.java 2d8b4d7 
bq.    src/main/java/org/apache/hadoop/hbase/constraint/Constraints.java 7825466 
bq.    src/main/java/org/apache/hadoop/hbase/constraint/package-info.java 6145ed5 
bq.    src/test/java/org/apache/hadoop/hbase/constraint/CheckConfigurationConstraint.java
c49098d 
bq.  
bq.  Diff: https://reviews.apache.org/r/3273/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  mvn clean test -P localTests -Dest=*Constraint* <- all tests pass.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Jesse
bq.  
bq.


                
> Constraints implementation and javadoc changes
> ----------------------------------------------
>
>                 Key: HBASE-5070
>                 URL: https://issues.apache.org/jira/browse/HBASE-5070
>             Project: HBase
>          Issue Type: Task
>            Reporter: Zhihong Yu
>
> This is continuation of HBASE-4605
> See Stack's comments https://reviews.apache.org/r/2579/#review3980

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message