hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5072) Support Max Value for Per-Store Metrics
Date Tue, 20 Dec 2011 06:17:31 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172968#comment-13172968
] 

Phabricator commented on HBASE-5072:
------------------------------------

nspiegelberg has commented on the revision "[jira] [HBASE-5072] Support Max Value for Per-Store
Metrics".
Added CCs: mbautin

INLINE COMMENTS
  src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java:387 note that
we're doing a pointer comparison here.  The 'this' pointer is being compared to a well-known
singleton.  This patter is used throughout the class.  I switched the logic to equals because
too many negations leads to confusion.
  src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java:234 correct.
 I talked to @mbautin about this today.  The idea is to reduce the number of heap allocations
when doing metrics.  I don't think this is as big an issue, since heap allocations on the
par-new space should be really efficient, but I'm keeping with the existing style

REVISION DETAIL
  https://reviews.facebook.net/D945

                
> Support Max Value for Per-Store Metrics
> ---------------------------------------
>
>                 Key: HBASE-5072
>                 URL: https://issues.apache.org/jira/browse/HBASE-5072
>             Project: HBase
>          Issue Type: Improvement
>          Components: metrics, regionserver
>            Reporter: Nicolas Spiegelberg
>            Assignee: Nicolas Spiegelberg
>            Priority: Minor
>             Fix For: 0.94.0
>
>         Attachments: D945.1.patch
>
>
> We were bit in our multi-tenant cluster because one of our Stores encountered a bug and
grew its StoreFile count.  We didn't notice this because the StoreFile count currently reported
by the RegionServer is an average of all Stores in the region.  For the per-Store metrics,
we should also record the max so we can notice outliers.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message