Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F1B6F9C77 for ; Sun, 6 Nov 2011 06:51:16 +0000 (UTC) Received: (qmail 99833 invoked by uid 500); 6 Nov 2011 06:51:16 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 99710 invoked by uid 500); 6 Nov 2011 06:51:16 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 99626 invoked by uid 99); 6 Nov 2011 06:51:15 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 06 Nov 2011 06:51:15 +0000 X-ASF-Spam-Status: No, hits=-2001.2 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 06 Nov 2011 06:51:12 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id BC866348A7 for ; Sun, 6 Nov 2011 06:50:51 +0000 (UTC) Date: Sun, 6 Nov 2011 06:50:51 +0000 (UTC) From: "Hadoop QA (Commented) (JIRA)" To: issues@hbase.apache.org Message-ID: <2120724166.4362.1320562251773.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <183487462.58048.1320370172283.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HBASE-4746) Use a random ZK client port in unit tests so we can run them in parallel MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HBASE-4746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144944#comment-13144944 ] Hadoop QA commented on HBASE-4746: ---------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12502644/4746-trunk-v2.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 39 new or modified tests. -1 javadoc. The javadoc tool appears to have generated -164 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 48 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.master.TestDistributedLogSplitting org.apache.hadoop.hbase.replication.TestMasterReplication org.apache.hadoop.hbase.replication.TestReplication org.apache.hadoop.hbase.regionserver.TestColumnSeeking Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/193//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/193//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/193//console This message is automatically generated. > Use a random ZK client port in unit tests so we can run them in parallel > ------------------------------------------------------------------------ > > Key: HBASE-4746 > URL: https://issues.apache.org/jira/browse/HBASE-4746 > Project: HBase > Issue Type: Improvement > Reporter: Mikhail Bautin > Attachments: 4746-trunk-v2.txt, D255.1.patch, D279.1.patch > > > The hard-coded ZK client port has long been a problem for running HBase test suite in parallel. The mini ZK cluster should run on a random free port, and that port should be passed to all parts of the unit tests that need to talk to the mini cluster. In fact, randomizing the port exposes a lot of places in the code where a new configuration is instantiated, and as a result the client tries to talk to the default ZK client port and times out. > The initial fix is for 0.89-fb, where it already allows to run unit tests in parallel in 10 minutes. A fix for the trunk will follow. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira