hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Hofhansl (Resolved) (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (HBASE-4800) Result.compareResults is incorrect
Date Wed, 16 Nov 2011 18:46:51 GMT

     [ https://issues.apache.org/jira/browse/HBASE-4800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Lars Hofhansl resolved HBASE-4800.
----------------------------------

      Resolution: Fixed
    Hadoop Flags: Reviewed

Committed to 0.90, 0.92, and trunk.
                
> Result.compareResults is incorrect
> ----------------------------------
>
>                 Key: HBASE-4800
>                 URL: https://issues.apache.org/jira/browse/HBASE-4800
>             Project: HBase
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 0.90.4, 0.92.0, 0.94.0
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>             Fix For: 0.92.0, 0.94.0, 0.90.5
>
>         Attachments: 4800.txt
>
>
> A coworker of mine (James Taylor) found a bug in Result.compareResults(...).
> This condition:
> {code}
>       if (!ourKVs[i].equals(replicatedKVs[i]) &&
>           !Bytes.equals(ourKVs[i].getValue(), replicatedKVs[i].getValue())) {
>         throw new Exception("This result was different: "
> {code}
> should be
> {code}
>       if (!ourKVs[i].equals(replicatedKVs[i]) ||
>           !Bytes.equals(ourKVs[i].getValue(), replicatedKVs[i].getValue())) {
>         throw new Exception("This result was different: "
> {code}
> Just checked, this is wrong in all branches.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message