hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Li Pi (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4752) Don't create an unnecessary LinkedList when evicting from the BlockCache
Date Mon, 07 Nov 2011 06:09:51 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145244#comment-13145244
] 

Li Pi commented on HBASE-4752:
------------------------------

This should work. I agree we should drain until we're below minsize, this seems to align with
the way the code has been written.

+1 from me.
                
> Don't create an unnecessary LinkedList when evicting from the BlockCache
> ------------------------------------------------------------------------
>
>                 Key: HBASE-4752
>                 URL: https://issues.apache.org/jira/browse/HBASE-4752
>             Project: HBase
>          Issue Type: Improvement
>          Components: performance, regionserver
>    Affects Versions: 0.90.4
>            Reporter: Benoit Sigoure
>            Assignee: Ted Yu
>            Priority: Minor
>             Fix For: 0.94.0
>
>         Attachments: 0001-HBASE-4752-Don-t-create-an-unnecessary-LinkedList-wh.patch,
4752-trunk-v2.txt, 4752-trunk.txt
>
>
> When evicting from the BlockCache, the code creates a LinkedList containing every single
block sorted by access time.  This list is created from a PriorityQueue.  I don't believe
it is necessary, as the PriorityQueue can be used directly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message