hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "nkeywal (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4798) Sleeps and synchronisation improvements for tests
Date Wed, 16 Nov 2011 23:41:53 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151638#comment-13151638

nkeywal commented on HBASE-4798:

(comment continued) actually Ted mentioned me an error he saw while testing another jira,
it could be related to this part of code as well.

At least we should change the test to make clear. In the test case, if I start with rubbish,
 the server should them start and then be fully available; I should be able to create a table
and put some data in it? Not only stop it as in today's test implementation?
> Sleeps and synchronisation improvements for tests
> -------------------------------------------------
>                 Key: HBASE-4798
>                 URL: https://issues.apache.org/jira/browse/HBASE-4798
>             Project: HBase
>          Issue Type: Improvement
>          Components: master, regionserver, test
>    Affects Versions: 0.94.0
>         Environment: all
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>         Attachments: 4798_trunk_all.v2.patch
> Multiple small changes:
> @commiters: Removing some sleeps made visible a bug on JVMClusterUtil#HMaster#waitForServerOnline,
so I had to add a synchro point. You may want to review this.
> JVMClusterUtil#HMaster#waitForServerOnline: removed, the condition was never met (test
on "!c && !!c"). Added a new synchronization point.
> AssignementManager#waitForAssignment: add a timeout on the wait => not stuck if the
notification is received before the wait.
> HMaster#loop: use a notification instead of a 1s sleep
> HRegionServer#waitForServerOnline: new method used by JVMClusterUtil#waitForServerOnline()
to replace a 1s sleep by a notification
> HRegionServer#getMaster() 1s sleeps replaced by one 0,1s sleep and one 0,2s sleep
> HRegionServer#stop: use a notification on sleeper to lower shutdown by 0,5s
> ZooKeeperNodeTracker#start: replace a recursive call by a loop
> ZooKeeperNodeTracker#blockUntilAvailable: add a timeout on the wait => not stuck if
the notification is received before the wait.
> HBaseTestingUtility#expireSession: use a timeout of 1s instead of 5s
> TestZooKeeper#testClientSessionExpired: use a timeout of 1s instead of 5s, with the change
on HBaseTestingUtility we are 60s faster
> TestRegionRebalancing#waitForAllRegionsAssigned: use a sleep of 0,2s instead of 1s
> TestRestartCluster#testClusterRestart: send all the table creation together, then check
creation, should be faster
> TestHLog: shutdown the whole cluster instead of DFS only (more standard) 
> JVMClusterUtil#startup: lower the sleep from 1s to 0,1s
> HConnectionManager#close: Zookeeper name in debug message from HConnectionManager after
connection close was always null because it was set to null in the delete.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message