hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hsieh (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4820) Distributed log splitting coding enhancement to make it easier to understand, no semantics change
Date Mon, 21 Nov 2011 20:18:51 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154443#comment-13154443

Jonathan Hsieh commented on HBASE-4820:

@Kannan, I'm looking at this from the point of view of someone who recently spent a many hours
reviewing the dist log splitting patches in aggregate and may be responsible for fixing issues
if it has problems.  I had a harder time than I'd prefer, and will likely have the same problem
again if there are problems in the future.  Doing a little bit of semantics preserving changes
such as making var/method/class names more descriptive and encapsulating pieces would go a
long way to make the code more easily and quickly understandable by more people.

Are you suggesting splitting these changes into smaller pieces such as:

* add better exception error messages.
* consolidate calls only used once. Ex: async callbacks submethods; inline finishInitailize
into SLM's constructor
* rename vague methods. ex: installTask(String taskName) might be better as enqueueSplitLog(String
logPath);  handleDeadWorker might be better as blacklistDeadWorker;  'exec(String name, Progressable)'
might be better as  'split(String logfilename, Progressable)'
* rename vague classes. ex: Task to SplitTask, TaskBatch to SplitTaskState/SplitTaskContext
* correct comments to be consistent with code (comments in SplitLogWorker talks about SUCCESS
state which acutally is DONE state).

> Distributed log splitting coding enhancement to make it easier to understand, no semantics
> -------------------------------------------------------------------------------------------------
>                 Key: HBASE-4820
>                 URL: https://issues.apache.org/jira/browse/HBASE-4820
>             Project: HBase
>          Issue Type: Improvement
>          Components: wal
>    Affects Versions: 0.94.0
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>              Labels: newbie
>             Fix For: 0.94.0
>         Attachments: 0001-HBASE-4820-Distributed-log-splitting-coding-enhancement-to-make----it-easier-to-understand,-no-semantics-change..patch,
> In reviewing distributed log splitting feature, we found some cosmetic issues.  They
make the code hard to understand.
> It will be great to fix them.  For this issue, there should be no semantic change.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message