hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4820) Distributed log splitting coding enhancement to make it easier to understand, no semantics change
Date Wed, 23 Nov 2011 18:35:40 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156043#comment-13156043
] 

Todd Lipcon commented on HBASE-4820:
------------------------------------

Can we meet in the middle with this patch? A few suggestions that would make the patch more
trivial to review:
- don't do the whitespace-only fixes in parts of the code you're not touching
- don't expand out the "import foo.*"s
- don't move the callback code to different parts of the file
- *do* fix variable names to conform to style, remove dead code, add javadoc, rename classes,
etc.

This should make the patch very easy to look over and make sure it doesn't break anything.
It'll then be easy for FB to pull it into their branch if they want.
                
> Distributed log splitting coding enhancement to make it easier to understand, no semantics
change
> -------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4820
>                 URL: https://issues.apache.org/jira/browse/HBASE-4820
>             Project: HBase
>          Issue Type: Improvement
>          Components: wal
>    Affects Versions: 0.94.0
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>              Labels: newbie
>             Fix For: 0.94.0
>
>         Attachments: 0001-HBASE-4820-Distributed-log-splitting-coding-enhancement-to-make----it-easier-to-understand,-no-semantics-change..patch,
0001-HBASE-4820-Distributed-log-splitting-coding-enhancement-to-make----it-easier-to-understand,-no-semantics-change..patch
>
>
> In reviewing distributed log splitting feature, we found some cosmetic issues.  They
make the code hard to understand.
> It will be great to fix them.  For this issue, there should be no semantic change.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message