hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.
Date Wed, 16 Nov 2011 19:12:53 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151433#comment-13151433
] 

jiraposter@reviews.apache.org commented on HBASE-4213:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1786/
-----------------------------------------------------------

(Updated 2011-11-16 19:12:03.308667)


Review request for Todd Lipcon, Andrew Purtell and Subbu Iyer.


Changes
-------

Patch addresses Lars' comments


Summary
-------

bq. From Subbu:
here is the latest patch that support alter_instant, an instant schema change command that
supports (Add, Modify, Delete column and Modify table) actions through ZK.

1. This pattern capitalizes on the fact that HRI's are now in HDFS and need not be sent over
again from Master to RS cloud on every schema change event.

2. Offers real time instant schema change as we bypass the explicit bulk reassign (unassign
+ assign) of regions from master to RS.

3. Offers fault tolerant schema change support as schema changes now go through ZK. Secondary
master taking over a failed schema change will be addressed through a separate JIRA.


Diffs (updated)
-----

  /src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/MasterServices.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableHandler.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/handler/ModifyTableHandler.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/handler/TableAddFamilyHandler.java 1202381

  /src/main/java/org/apache/hadoop/hbase/master/handler/TableDeleteFamilyHandler.java 1202381

  /src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java 1202523 
  /src/main/java/org/apache/hadoop/hbase/master/handler/TableModifyFamilyHandler.java 1202381

  /src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/regionserver/OnlineRegions.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/zookeeper/MasterSchemaChangeTracker.java PRE-CREATION

  /src/main/java/org/apache/hadoop/hbase/zookeeper/SchemaChangeTracker.java PRE-CREATION 
  /src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java 1202381 
  /src/main/resources/hbase-default.xml 1202381 
  /src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChange.java PRE-CREATION

  /src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChangeFailover.java PRE-CREATION

  /src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java 1202381 
  /src/test/java/org/apache/hadoop/hbase/util/MockRegionServerServices.java 1202381 

Diff: https://reviews.apache.org/r/1786/diff


Testing
-------

Unit tests pass.


Thanks,

Ted


                
> Support for fault tolerant, instant schema updates with out master's intervention (i.e
with out enable/disable and bulk assign/unassign) through ZK.
> ----------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4213
>                 URL: https://issues.apache.org/jira/browse/HBASE-4213
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Subbu M Iyer
>            Assignee: Subbu M Iyer
>             Fix For: 0.94.0
>
>         Attachments: 4213-0.92.txt, 4213-0.92.v2, 4213-101211-Support_instant_schema_changes_through_ZK.patch,
4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch, 4213-Instant_Schema_change_through_ZK.patch,
4213-Nov-2-2011_patch_.patch, 4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch,
4213-V10-Support_instant_schema_changes_through_ZK.patch, 4213-V5-Support_instant_schema_changes_through_ZK.patch,
4213-V7-Support_instant_schema_changes_through_ZK.patch, 4213-V8-Support_instant_schema_changes_through_ZK.patch,
4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-v9.txt, 4213.v6, HBASE-4213-Instant_schema_change.patch,
HBASE-4213_Instant_schema_change_-Version_2_.patch, HBASE_Instant_schema_change-version_3_.patch
>
>
> This Jira is a slight variation in approach to what is being done as part of 
> https://issues.apache.org/jira/browse/HBASE-1730
> Support instant schema updates such as Modify Table, Add Column, Modify Column operations:
> 1. With out enable/disabling the table.
> 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message