hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4739) Master dying while going to close a region can leave it in transition forever
Date Tue, 22 Nov 2011 00:19:40 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154758#comment-13154758
] 

stack commented on HBASE-4739:
------------------------------

Is this state misnamed?  Is the comment below saying that the master sets CLOSING state?

{code}
-    RS_ZK_REGION_CLOSING      (1),   // RS is in process of closing a region
+    RS_ZK_REGION_CLOSING      (1),   // Master adds this region as closing in ZK
{code}

Why not just print out state rather than do this in log message:

{code}
(state.isPendingClose() ? "pending close " : "closing ") +
{code}

I'm not up on what rest of patch does so can't comment more.

Thanks for digging in Jinchao.


                
> Master dying while going to close a region can leave it in transition forever
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-4739
>                 URL: https://issues.apache.org/jira/browse/HBASE-4739
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.4
>            Reporter: Jean-Daniel Cryans
>            Assignee: gaojinchao
>            Priority: Minor
>             Fix For: 0.92.0, 0.94.0, 0.90.5
>
>         Attachments: 4739_trial2.patch, 4739_trialV3.patch, HBASE-4739_Trunk.patch, HBASE-4739_Trunk_V2.patch,
HBASE-4739_trail5.patch, HBASE-4739_trial.patch
>
>
> I saw this in the aftermath of HBASE-4729 on a 0.92 refreshed yesterday, when the master
died it had just created the RIT znode for a region but didn't tell the RS to close it yet.
> When the master restarted it saw the znode and started printing this:
> {quote}
> 2011-11-03 00:02:49,130 INFO org.apache.hadoop.hbase.master.AssignmentManager: Regions
in transition timed out:  TestTable,0007560564,1320253568406.f76899564cabe7e9857c3aeb526ec9dc.
state=CLOSING, ts=1320253605285, server=sv4r11s38,62003,1320195046948
> 2011-11-03 00:02:49,130 INFO org.apache.hadoop.hbase.master.AssignmentManager: Region
has been CLOSING for too long, this should eventually complete or the server will expire,
doing nothing
> {quote}
> It's never going to happen, and it's blocking balancing.
> I'm marking this as minor since I believe this situation is pretty rare unless you hit
other bugs while trying out stuff to root bugs out.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message