hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4820) Distributed log splitting coding enhancement to make it easier to understand, no semantics change
Date Mon, 21 Nov 2011 03:29:52 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153966#comment-13153966
] 

jiraposter@reviews.apache.org commented on HBASE-4820:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2895/#review3385
-----------------------------------------------------------



src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java
<https://reviews.apache.org/r/2895/#comment7563>

    handleDeadWorkers would be a better method name.



src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java
<https://reviews.apache.org/r/2895/#comment7562>

    Please remove white space.



src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java
<https://reviews.apache.org/r/2895/#comment7564>

    retry_count is the remaining count. This log message should be clearer.



src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java
<https://reviews.apache.org/r/2895/#comment7565>

    Can we implement this item now ?



src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java
<https://reviews.apache.org/r/2895/#comment7566>

    We should say 'remaining retries='



src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java
<https://reviews.apache.org/r/2895/#comment7567>

    Please adjust indentation.



src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java
<https://reviews.apache.org/r/2895/#comment7571>

    Please adjust indentation for these 4 lines.



src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java
<https://reviews.apache.org/r/2895/#comment7570>

    Should read 'splitlog workers'



src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java
<https://reviews.apache.org/r/2895/#comment7572>

    Adjust indentation, please.


- Ted


On 2011-11-21 02:06:29, Jimmy Xiang wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2895/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-11-21 02:06:29)
bq.  
bq.  
bq.  Review request for hbase, Todd Lipcon and Jonathan Robie.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Distributed log splitting coding enhancement to make it easier to understand, no semantics
change.
bq.  It is some issue raised during the code review in back porting this feature to CDH.
bq.  
bq.  
bq.  This addresses bug HBASE-4820.
bq.      https://issues.apache.org/jira/browse/HBASE-4820
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java f7ef653 
bq.    src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java b9a3a2c 
bq.    src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java 7dd67e9 
bq.    src/main/java/org/apache/hadoop/hbase/regionserver/SplitLogWorker.java 1d329b0 
bq.    src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java 21747b1 
bq.    src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java 51daa1f

bq.    src/test/java/org/apache/hadoop/hbase/master/TestSplitLogManager.java c8684ec 
bq.    src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitLogWorker.java 84d76e8

bq.  
bq.  Diff: https://reviews.apache.org/r/2895/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Ran unit tests. Non-flaky tests are green. Two client tests didn't pass, which are not
related to this change.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Jimmy
bq.  
bq.


                
> Distributed log splitting coding enhancement to make it easier to understand, no semantics
change
> -------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4820
>                 URL: https://issues.apache.org/jira/browse/HBASE-4820
>             Project: HBase
>          Issue Type: Improvement
>          Components: wal
>    Affects Versions: 0.94.0
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>              Labels: newbie
>             Fix For: 0.94.0
>
>         Attachments: 0001-HBASE-4820-Distributed-log-splitting-coding-enhancement-to-make----it-easier-to-understand,-no-semantics-change..patch,
0001-HBASE-4820-Distributed-log-splitting-coding-enhancement-to-make----it-easier-to-understand,-no-semantics-change..patch
>
>
> In reviewing distributed log splitting feature, we found some cosmetic issues.  They
make the code hard to understand.
> It will be great to fix them.  For this issue, there should be no semantic change.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message