hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mikhail Bautin (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4746) Use a random ZK client port in unit tests so we can run them in parallel
Date Tue, 08 Nov 2011 00:08:51 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145979#comment-13145979
] 

Mikhail Bautin commented on HBASE-4746:
---------------------------------------

> Why did the statics have to be removed from TestMasterReplication but not from TestReplication
and TestMultislaveReplication (and I do apologize for the cut-and-pasting here)?

@Lars: I am not sure why TestReplication and TestMultislveReplication worked fine without
changing them to set up and tear down a mini cluster for every test. These tests are complex
enough and sequential test methods were most likely stepping on each other's state in TestMasterReplication.
I think it only makes sense to isolate test methods within a unit test.
                
> Use a random ZK client port in unit tests so we can run them in parallel
> ------------------------------------------------------------------------
>
>                 Key: HBASE-4746
>                 URL: https://issues.apache.org/jira/browse/HBASE-4746
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Mikhail Bautin
>            Assignee: Mikhail Bautin
>             Fix For: 0.94.0
>
>         Attachments: 4746-trunk-v2.txt, D255.1.patch, D255.2.patch, D279-trunk-v5.txt,
D279-trunk-v7.txt, D279.1.patch, D279.2.patch, D279.3.patch, D279.4.patch, D279.5.patch, D279.6.patch,
D279.7.patch, D279.92
>
>
> The hard-coded ZK client port has long been a problem for running HBase test suite in
parallel. The mini ZK cluster should run on a random free port, and that port should be passed
to all parts of the unit tests that need to talk to the mini cluster. In fact, randomizing
the port exposes a lot of places in the code where a new configuration is instantiated, and
as a result the client tries to talk to the default ZK client port and times out.
> The initial fix is for 0.89-fb, where it already allows to run unit tests in parallel
in 10 minutes. A fix for the trunk will follow.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message