hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4686) [89-fb] Fix per-store metrics aggregation
Date Mon, 07 Nov 2011 18:26:52 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145678#comment-13145678

Phabricator commented on HBASE-4686:

nspiegelberg has commented on the revision "[jira] [HBASE-4686] [89-fb] Fix per-store metrics

  is there any functional problem with this code?  I don't see any code guideline violations
severe enough to make for a negative impact on inheriting the code.  Maybe reading Code Complete
would be a good way to adjust focus for code guideline severity on formatting that we can't
automate away:  http://www.amazon.com/Code-Complete-Practical-Handbook-Construction/dp/0735619670/


> [89-fb] Fix per-store metrics aggregation 
> ------------------------------------------
>                 Key: HBASE-4686
>                 URL: https://issues.apache.org/jira/browse/HBASE-4686
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Mikhail Bautin
>            Assignee: Mikhail Bautin
>         Attachments: D87.1.patch, D87.2.patch, D87.3.patch, HBASE-4686-TestRegionServerMetics-and-Store-metric-a-20111027134023-cc718144.patch,
> In r1182034 per-Store metrics were broken, because the aggregation of StoreFile metrics
over all stores in a region was replaced by overriding them every time. We saw these metrics
drop by a factor of numRegions on a production cluster -- thanks to Kannan for noticing this!
 We need to fix the metrics and add a unit test to ensure regressions like this don't happen
in the future.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message