hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-3939) Some crossports of Hadoop IPC fixes
Date Fri, 04 Nov 2011 00:09:32 GMT

    [ https://issues.apache.org/jira/browse/HBASE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143634#comment-13143634
] 

stack commented on HBASE-3939:
------------------------------

Sorry about not putting it up in rb.  Will do next time.

On setupResponse above, there is a byte which says whether an error or not (or error and length
of the rpc provided).  Passing the Status, I don't see FATAL being used.  So why introduce
it?  Just so its in place when we want to use it later?

If this is so, see what you think of the following patch (it puts Status into the back and
forth though it does not really exploit it -- hadoop seems to have come to rely on it but
our stuff is old in this regard -- and it does your suggestion around VersionedWritable too).
                
> Some crossports of Hadoop IPC fixes
> -----------------------------------
>
>                 Key: HBASE-3939
>                 URL: https://issues.apache.org/jira/browse/HBASE-3939
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Todd Lipcon
>            Priority: Critical
>             Fix For: 0.92.0
>
>         Attachments: 3939-v2.txt, 3939-v3.txt, 3939-v4.txt, 3939-v5.txt, 3939-v6.txt,
3939-v7.txt, 3939.txt
>
>
> A few fixes from Hadoop IPC that we should probably cross-port into our copy:
> - HADOOP-7227: remove the protocol version check at call time
> - HADOOP-7146: fix a socket leak in server
> - HADOOP-7121: fix behavior when response serialization throws an exception
> - HADOOP-7346: send back nicer error response when client is using an out of date IPC
version

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message