hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4746) Use a random ZK client port in unit tests so we can run them in parallel
Date Sun, 06 Nov 2011 23:50:52 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145160#comment-13145160
] 

Phabricator commented on HBASE-4746:
------------------------------------

mbautin has commented on the revision "[jira] [HBASE-4746] Use a random ZK client port in
unit tests so we can run them in parallel".

  An update on unit test runs:

  Run 1: 239 test classes run, 1092 tests, 16 min 13 sec. TestRegionServerCoprocessorExceptionWithAbort
failed but succeeded when rerun locally
  Run 2: 239 test classes run, 1096 tests, 9 min 39 sec, no failures.

  I will look into the discrepancy between the number of tests in these two cases -- but I
think this is because the MapReduce framework can run the same task multiple times ("speculative
execution"). So I guess we are good to do with this patch.

REVISION DETAIL
  https://reviews.facebook.net/D279

                
> Use a random ZK client port in unit tests so we can run them in parallel
> ------------------------------------------------------------------------
>
>                 Key: HBASE-4746
>                 URL: https://issues.apache.org/jira/browse/HBASE-4746
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Mikhail Bautin
>            Assignee: Mikhail Bautin
>         Attachments: 4746-trunk-v2.txt, D255.1.patch, D255.2.patch, D279.1.patch, D279.2.patch,
D279.3.patch
>
>
> The hard-coded ZK client port has long been a problem for running HBase test suite in
parallel. The mini ZK cluster should run on a random free port, and that port should be passed
to all parts of the unit tests that need to talk to the mini cluster. In fact, randomizing
the port exposes a lot of places in the code where a new configuration is instantiated, and
as a result the client tries to talk to the default ZK client port and times out.
> The initial fix is for 0.89-fb, where it already allows to run unit tests in parallel
in 10 minutes. A fix for the trunk will follow.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message