hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4820) Distributed log splitting coding enhancement to make it easier to understand, no semantics change
Date Wed, 23 Nov 2011 23:10:41 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156382#comment-13156382
] 

jiraposter@reviews.apache.org commented on HBASE-4820:
------------------------------------------------------



bq.  On 2011-11-23 22:51:05, Todd Lipcon wrote:
bq.  > src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java, line 636
bq.  > <https://reviews.apache.org/r/2895/diff/3/?file=59937#file59937line636>
bq.  >
bq.  >     put the edits where?

* Parse a single hlog and put the edits in entryBuffers


- Jimmy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2895/#review3492
-----------------------------------------------------------


On 2011-11-23 19:58:09, Jimmy Xiang wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2895/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-11-23 19:58:09)
bq.  
bq.  
bq.  Review request for hbase, Todd Lipcon and Jonathan Robie.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Distributed log splitting coding enhancement to make it easier to understand, no semantics
change.
bq.  It is some issue raised during the code review in back porting this feature to CDH.
bq.  
bq.  
bq.  This addresses bug HBASE-4820.
bq.      https://issues.apache.org/jira/browse/HBASE-4820
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 2101054 
bq.    src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java d7a648d 
bq.    src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java 7dd67e9 
bq.    src/main/java/org/apache/hadoop/hbase/regionserver/SplitLogWorker.java 1d329b0 
bq.    src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java 21747b1 
bq.    src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java 51daa1f

bq.    src/test/java/org/apache/hadoop/hbase/master/TestSplitLogManager.java c8684ec 
bq.  
bq.  Diff: https://reviews.apache.org/r/2895/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Ran unit tests. Non-flaky tests are green. Two client tests didn't pass, which are not
related to this change.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Jimmy
bq.  
bq.


                
> Distributed log splitting coding enhancement to make it easier to understand, no semantics
change
> -------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4820
>                 URL: https://issues.apache.org/jira/browse/HBASE-4820
>             Project: HBase
>          Issue Type: Improvement
>          Components: wal
>    Affects Versions: 0.94.0
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>              Labels: newbie
>             Fix For: 0.94.0
>
>         Attachments: 0001-HBASE-4820-Distributed-log-splitting-coding-enhancement-to-make----it-easier-to-understand,-no-semantics-change..patch,
0001-HBASE-4820-Distributed-log-splitting-coding-enhancement-to-make----it-easier-to-understand,-no-semantics-change..patch,
0001-HBASE-4820-Minor-distributed-log-splitting-enhanceme.patch, 0001-HBASE-4820-Minor-distributed-log-splitting-enhanceme.patch
>
>
> In reviewing distributed log splitting feature, we found some cosmetic issues.  They
make the code hard to understand.
> It will be great to fix them.  For this issue, there should be no semantic change.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message