hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4627) Ability to specify a custom start/end to RegionSplitter
Date Mon, 07 Nov 2011 16:10:53 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145581#comment-13145581
] 

Phabricator commented on HBASE-4627:
------------------------------------

Karthik has commented on the revision "[jira] [HBASE-4627] Ability to specify a custom start/end
to RegionSplitter".

INLINE COMMENTS
  src/main/java/org/apache/hadoop/hbase/util/Bytes.java:1417 I thought of a simpler case which
it seemed to not work for:

  Let's take the range [0,10] and request 5 splits. If exclusive, we would do diffBI = (10
- 0)/5 = 2, so we get (0-2, 2-4, 4-6, 6-8, 8-10). If inclusive, diffBI would become 3, so
we would get (0-3, 3-6, 6-9, 9-10) - which is 4 regions.

  But if we added the 1 to the stopBI, the we would get:
  diffBI = (11 - 0)/5 = 2.2, which would give us 5 regions:
   (0-2.2, 2.2-4.4, 4.4-6.6, 6.6-8.8, 8.8-10)

  So, would it not be better to do:

  startBI = new BigInteger(0x00)
  stopBI = new BigInteger(0xFF) + 1
  diff BI = 255.subtract(0)

REVISION DETAIL
  https://reviews.facebook.net/D39

COMMITS
  https://reviews.facebook.net/rHBASE1196256
  https://reviews.facebook.net/rHBASE1196772

                
> Ability to specify a custom start/end to RegionSplitter
> -------------------------------------------------------
>
>                 Key: HBASE-4627
>                 URL: https://issues.apache.org/jira/browse/HBASE-4627
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.94.0
>            Reporter: Nicolas Spiegelberg
>            Assignee: Nicolas Spiegelberg
>         Attachments: D39.1.patch, D39.1.patch
>
>
> HBASE-4489 changed the default endKey on HexStringSplit from 7FFF... to FFFF...  While
this is correct, existing users of 0.90 RegionSplitter have 7FFF as the end key in their schema
and the last region will not split properly under this new code.  We need to let the user
specify a custom start/end key range for when situations like this arise.  Optimally, we should
also write the start/end key in META so we could figure this out implicitly instead of requiring
the user to explicitly specify it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message