hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4773) HBaseAdmin leaks ZooKeeper connections
Date Fri, 25 Nov 2011 15:43:40 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157198#comment-13157198
] 

Ted Yu commented on HBASE-4773:
-------------------------------

In TRUNK, we retry connecting to master several times:
{code}
      } catch (MasterNotRunningException mnre) {
        HConnectionManager.deleteStaleConnection(this.connection);
        this.connection = HConnectionManager.getConnection(this.conf);
{code}

@Xufeng:
Can you implement similar retry loop for 0.90 ?

Thanks
                
> HBaseAdmin leaks ZooKeeper connections
> --------------------------------------
>
>                 Key: HBASE-4773
>                 URL: https://issues.apache.org/jira/browse/HBASE-4773
>             Project: HBase
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 0.90.4
>            Reporter: gaojinchao
>            Priority: Critical
>             Fix For: 0.90.5
>
>         Attachments: 4773.patch
>
>
> When master crashs, HBaseAdmin will leaks ZooKeeper connections
> I think we should close the zk connetion when throw MasterNotRunningException
>  public HBaseAdmin(Configuration c)
>   throws MasterNotRunningException, ZooKeeperConnectionException {
>     this.conf = HBaseConfiguration.create(c);
>     this.connection = HConnectionManager.getConnection(this.conf);
>     this.pause = this.conf.getLong("hbase.client.pause", 1000);
>     this.numRetries = this.conf.getInt("hbase.client.retries.number", 10);
>     this.retryLongerMultiplier = this.conf.getInt("hbase.client.retries.longer.multiplier",
10);
>     //we should add this code and close the zk connection
>     try{
>       this.connection.getMaster();
>     }catch(MasterNotRunningException e){
>       HConnectionManager.deleteConnection(conf, false);
>       throw e;      
>     }
>   }

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message