hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jimmy Xiang (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4887) Write full enum name of Compression.Algorithm into HFile
Date Tue, 29 Nov 2011 01:17:40 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159011#comment-13159011

Jimmy Xiang commented on HBASE-4887:

Using full enum name is great. Since the ordinal in the file is an integer, to use enum name
which is a string, we may need to increase the file version, or using some trick (for example,
writing -1, then the enum name).

How about a different solution? Introducing an Id to the enum, for those existing Compression.Algorithm,
we use their current ordinal as their Ids. For new compress algorithms, their ordinal will
not matter any more.
> Write full enum name of Compression.Algorithm into HFile
> --------------------------------------------------------
>                 Key: HBASE-4887
>                 URL: https://issues.apache.org/jira/browse/HBASE-4887
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
> Currently the ordinal of compression algorithms is used.
> This places unnecessary constraint when new compress algorithm is added.
> We should write full enum name of Compression.Algorithm into HFile

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message