hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4768) Per-(table, columnFamily) metrics with configurable table name inclusion
Date Tue, 15 Nov 2011 00:44:51 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150119#comment-13150119
] 

Hadoop QA commented on HBASE-4768:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12503521/D363.4.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 37 new or modified tests.

    -1 javadoc.  The javadoc tool appears to have generated -163 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 51 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.io.hfile.TestHFileBlock

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/246//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/246//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/246//console

This message is automatically generated.
                
> Per-(table, columnFamily) metrics with configurable table name inclusion
> ------------------------------------------------------------------------
>
>                 Key: HBASE-4768
>                 URL: https://issues.apache.org/jira/browse/HBASE-4768
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Mikhail Bautin
>            Assignee: Mikhail Bautin
>         Attachments: D363.1.patch, D363.2.patch, D363.3.patch, D363.4.patch
>
>
> As we kept adding more granular block read and block cache usage statistics, a combinatorial
explosion of various cases to monitor started to happen, especially when we wanted both per-table/column
family/block type statistics and aggregate statistics on various subsets of these dimensions.
Here, we un-clutters HFile readers, LruBlockCache, StoreFile, etc. by creating a centralized
class that knows how to update all kinds of per-table/CF/block type counters. 
> Table name and column family configuration have been pushed to a base class, SchemaConfigured.
This is convenient as many of existing classes that have these properties (HFile readers/writers,
HFile blocks, etc.) did not have a base class. Whether to collect per-(table, columnFamily)
or per-columnFamily only metrics can be configured with the hbase.metrics.showTableName configuration
key. We don't expect this configuration to change at runtime, so we cache the setting statically
and log a warning when an attempt is made to flip it once already set. This way we don't have
to pass configuration to a lot more places, e.g. everywhere an HFile reader is instantiated.
> Thanks to Liyin for his initial version of per-table metrics patch and a lot of valuable
feedback.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message