hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Hofhansl (Issue Comment Edited) (JIRA)" <j...@apache.org>
Subject [jira] [Issue Comment Edited] (HBASE-4838) Port 2856 (TestAcidGuarantee is failing) to 0.92
Date Sat, 26 Nov 2011 00:32:40 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157345#comment-13157345
] 

Lars Hofhansl edited comment on HBASE-4838 at 11/26/11 12:30 AM:
-----------------------------------------------------------------

Finally found the problem!!
It was indeed a problem in HalfStoreFileReader (as Todd and Stack have suggested all along).
HalfStoreFileReader did not have a getScanner(final boolean cacheBlocks, final boolean pread,
final boolean isCompaction) method, and hence the super method was called, returning a "normal"
ScannerV2, instead of the inner HFileScanner instance.

bq. Reference.java and HalfStoreFileReader.java are identical between 0.92 and trunk

I don't know what I was comparing here (must have been late in the night), but they are different
and that difference was exactly the problem. Could have saved myself about 16 hours of debugging.

                
      was (Author: lhofhansl):
    Finally found the problem!!
It was indeed a problem in HalfStoreFileReader (as Todd and Stack have suggested all along).
HalfStoreFileReader did not have a getScanner(final boolean cacheBlocks, final boolean pread,
final boolean isCompaction) method, and hence the super method was called returning a normal
reader.

bq. Reference.java and HalfStoreFileReader.java are identical between 0.92 and trunk

I don't know what I was comparing here (must have been late in the night), but they are different
and that difference was exactly the problem. Could have saved myself about 16 hours of debugging.

                  
> Port 2856 (TestAcidGuarantee is failing) to 0.92
> ------------------------------------------------
>
>                 Key: HBASE-4838
>                 URL: https://issues.apache.org/jira/browse/HBASE-4838
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>             Fix For: 0.92.0
>
>         Attachments: 4838-v1.txt, 4838-v3.txt
>
>
> Moving back port into a separate issue (as suggested by JonH), because this not trivial.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message