hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4716) Improve locking for single column family bulk load
Date Wed, 02 Nov 2011 18:23:33 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142382#comment-13142382
] 

Todd Lipcon commented on HBASE-4716:
------------------------------------

bq. When familyPaths is null, hasMultipleColumnFamilies() returns false.

familyPaths should never be null. It is an error for a user to pass a null value to this RPC
- the iteration later in bulkLoadsFile (line 2831) would throw NPE. So there is no need to
concern ourselves with what hasMultipleColumnFamilies would return when passed null. Indeed
we could add a Preconditions.checkNotNull at the top of bulkLoadHFiles.
                
> Improve locking for single column family bulk load
> --------------------------------------------------
>
>                 Key: HBASE-4716
>                 URL: https://issues.apache.org/jira/browse/HBASE-4716
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Critical
>             Fix For: 0.92.0
>
>         Attachments: 4716-v2.txt, 4716.addendum, 4716.txt
>
>
> HBASE-4552 changed the locking behavior for single column family bulk load, namely we
don't need to take write lock.
> A read lock would suffice in this scenario.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message