hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4478) Improve AssignmentManager.handleRegion so that it can process certain ZK state in the case of RS offline
Date Thu, 10 Nov 2011 20:35:51 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147989#comment-13147989
] 

Hadoop QA commented on HBASE-4478:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12503274/4478-v2.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 javadoc.  The javadoc tool appears to have generated -164 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 51 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/225//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/225//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/225//console

This message is automatically generated.
                
> Improve AssignmentManager.handleRegion so that it can process certain ZK state in the
case of RS offline
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4478
>                 URL: https://issues.apache.org/jira/browse/HBASE-4478
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ming Ma
>            Assignee: ramkrishna.s.vasudevan
>         Attachments: 4478-v2.txt, HBASE-4478_1.patch
>
>
> Currently AssignmentManager.handleRegion skips processing of ZK event change if the RS
is offline. It relies on TimeoutMonitor and ServerShutdownHandler to process RIT.
>       // Verify this is a known server
>       if (!serverManager.isServerOnline(sn) &&
>           !this.master.getServerName().equals(sn)) {
>         LOG.warn("Attempted to handle region transition for server but " +
>           "server is not online: " + Bytes.toString(data.getRegionName()));
>         return;
>       }
> For certain states like OPENED, OPENING, FAILED_OPEN, CLOSED, it can continue the progressing
even if the RS is offline.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message