hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4878) Master crash when splitting hlog may cause data loss
Date Mon, 28 Nov 2011 22:43:40 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158879#comment-13158879
] 

Hudson commented on HBASE-4878:
-------------------------------

Integrated in HBase-TRUNK #2494 (See [https://builds.apache.org/job/HBase-TRUNK/2494/])
    HBASE-4878  Master crash when splitting hlog may cause data loss (Chunhui Shen)

tedyu : 
Files : 
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java

                
> Master crash when splitting hlog may cause data loss
> ----------------------------------------------------
>
>                 Key: HBASE-4878
>                 URL: https://issues.apache.org/jira/browse/HBASE-4878
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: chunhui shen
>            Assignee: chunhui shen
>             Fix For: 0.92.0, 0.94.0
>
>         Attachments: hbase-4878.diff, hbase-4878v2.patch
>
>
> Let's see the code of HlogSplitter#splitLog(final FileStatus[] logfiles)
> {code}
> private List<Path> splitLog(final FileStatus[] logfiles) throws IOException {
>  try {
>   for (FileStatus log : logfiles) {
>   parseHLog(in, logPath, entryBuffers, fs, conf, skipErrors);
>  }
>  archiveLogs(srcDir, corruptedLogs, processedLogs, oldLogDir, fs, conf);
>  } finally {
>       status.setStatus("Finishing writing output logs and closing down.");
>       splits = outputSink.finishWritingAndClose();
>     }
> }
> {code}
> If master is killed, after finishing archiveLogs(srcDir, corruptedLogs, processedLogs,
oldLogDir, fs, conf), 
> but before finishing splits = outputSink.finishWritingAndClose();
> Log date would loss!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message