hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4752) Don't create an unnecessary LinkedList when evicting from the BlockCache
Date Sun, 13 Nov 2011 23:39:52 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149394#comment-13149394
] 

Hudson commented on HBASE-4752:
-------------------------------

Integrated in HBase-TRUNK #2434 (See [https://builds.apache.org/job/HBase-TRUNK/2434/])
    HBASE-4752 Don't create an unnecessary LinkedList when evicting from the BlockCache

tedyu : 
Files : 
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/CachedBlockQueue.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/io/hfile/TestCachedBlockQueue.java

                
> Don't create an unnecessary LinkedList when evicting from the BlockCache
> ------------------------------------------------------------------------
>
>                 Key: HBASE-4752
>                 URL: https://issues.apache.org/jira/browse/HBASE-4752
>             Project: HBase
>          Issue Type: Improvement
>          Components: performance, regionserver
>    Affects Versions: 0.90.4
>            Reporter: Benoit Sigoure
>            Assignee: Ted Yu
>            Priority: Minor
>             Fix For: 0.94.0
>
>         Attachments: 0001-HBASE-4752-Don-t-create-an-unnecessary-LinkedList-wh.patch,
4752-trunk-v2.txt, 4752-trunk.txt
>
>
> When evicting from the BlockCache, the code creates a LinkedList containing every single
block sorted by access time.  This list is created from a PriorityQueue.  I don't believe
it is necessary, as the PriorityQueue can be used directly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message