Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AE7BE91EB for ; Mon, 31 Oct 2011 23:58:15 +0000 (UTC) Received: (qmail 95198 invoked by uid 500); 31 Oct 2011 23:58:15 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 95160 invoked by uid 500); 31 Oct 2011 23:58:15 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 95152 invoked by uid 99); 31 Oct 2011 23:58:15 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 31 Oct 2011 23:58:15 +0000 X-ASF-Spam-Status: No, hits=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of apache@osuosl.org designates 140.211.166.137 as permitted sender) Received: from [140.211.166.137] (HELO fraxinus.osuosl.org) (140.211.166.137) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 31 Oct 2011 23:58:09 +0000 Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 39D97101EAB; Mon, 31 Oct 2011 23:57:48 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id d61lLKALfYQR; Mon, 31 Oct 2011 23:57:47 +0000 (UTC) Received: from facebook1.osuosl.org (facebook1.osuosl.org [140.211.15.127]) by fraxinus.osuosl.org (Postfix) with ESMTP id 5D90B1009B4; Mon, 31 Oct 2011 23:57:47 +0000 (UTC) Received: by facebook1.osuosl.org (Postfix, from userid 81) id 3CFAE61277; Mon, 31 Oct 2011 23:57:47 +0000 (UTC) To: jira@apache.org Date: Mon, 31 Oct 2011 23:57:47 +0000 From: "mbautin (Mikhail Bautin)" Cc: issues@hbase.apache.org Reply-to: "mbautin (Mikhail Bautin)" Subject: [Differential] [Commented On] D87: [jira] [HBASE-4686] [89-fb] Fix per-store metrics aggregation Message-ID: X-Priority: 3 Thread-Topic: [jira] [HBASE-4686] [89-fb] Fix per-store metrics aggregation X-Herald-Rules: none In-Reply-To: References: Thread-Index: MTBhZTU1YjJjOWNmZjYxZWIxNGFmOWFhZGJmIE6vNfs= X-Mail-Transport-Agent: MetaMTA MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-Virus-Checked: Checked by ClamAV on apache.org mbautin has commented on the revision "[jira] [HBASE-4686] [89-fb] Fix per-store metrics aggregation ". OK, this is now becoming a code style discussion, which is not a bad thing once in a while :) In general, the style guide for HBase seems to point to Oracle (former Sun)'s coding conventions: http://www.oracle.com/technetwork/java/codeconvtoc-136057.html, with the part pertaining to Javadoc at http://www.oracle.com/technetwork/java/javase/documentation/index-137868.html. I guess it might not be a bad idea to actually read those docs some time... INLINE COMMENTS src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java:386 Actually I a lot of places around the codebase don't have these empty lines inside javadoc comments, and I think it is not necessary here. Java formatter adds trailing whitespace to those empty lines, which is annoying. I did not find a requirement that these lines have to be there at http://www.oracle.com/technetwork/java/javase/documentation/index-137868.html (although I did not read that entire style guide). I will expand the documentation of tmpMap. src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java:554 Will fix. src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java:704 Agreed. src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java:1148 I think this saves space and is OK for one-line comments. This parses fine by Javadoc. src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java:1157 This empty line separates the bulky function header and the function body. src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java:1219 I will add one between 1218 and 1219. src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerMetrics.java:90 OK. src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerMetrics.java:119 This one is a matter of preference. There is one at the top, so I will keep the one at the bottom of the class definition. REVISION DETAIL https://reviews.facebook.net/D87