Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 10 Oct 2011 23:36:32 +0000 (UTC)
From: "jiraposter@reviews.apache.org (Commented) (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <95185145.17006.1318289792230.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-2856) TestAcidGuarantee broken on trunk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-2856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124575#comment-13124575 ] 

jiraposter@reviews.apache.org commented on HBASE-2856:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2224/
-----------------------------------------------------------

(Updated 2011-10-10 23:35:00.552025)


Review request for Ted Yu, Michael Stack, Kannan Muthukkaruppan, and Karthik Ranganathan.


Changes
-------

rename MAX_MEMSTORE_KEY to MAX_MEMSTORE_TS_KEY


Summary
-------

address the 2856 issues by writing the memstoreTS to the disk.

version v11 of the patch.

uploading it here for easier review process.


This addresses bug HBASE-2856.
    https://issues.apache.org/jira/browse/HBASE-2856


Diffs (updated)
-----

  /src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileReader.java 1181113 
  /src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV1.java 1181113 
  /src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java 1181113 
  /src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterV2.java 1181113 
  /src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 1181113 
  /src/main/java/org/apache/hadoop/hbase/regionserver/ReadWriteConsistencyControl.java 1181113 
  /src/main/java/org/apache/hadoop/hbase/regionserver/ScanQueryMatcher.java 1181113 
  /src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 1181113 
  /src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java 1181113 
  /src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java 1181113 
  /src/test/java/org/apache/hadoop/hbase/TestAcidGuarantees.java 1181113 
  /src/test/java/org/apache/hadoop/hbase/io/hfile/TestCacheOnWrite.java 1181113 
  /src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileWriterV2.java 1181113 
  /src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile.java 1181113 

Diff: https://reviews.apache.org/r/2224/diff


Testing
-------

mvn test


Thanks,

Amitanand


> TestAcidGuarantee broken on trunk 
> ----------------------------------
>
>                 Key: HBASE-2856
>                 URL: https://issues.apache.org/jira/browse/HBASE-2856
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.89.20100621
>            Reporter: ryan rawson
>            Assignee: Amitanand Aiyer
>            Priority: Blocker
>             Fix For: 0.94.0
>
>         Attachments: 2856-v2.txt, 2856-v3.txt, 2856-v4.txt, 2856-v5.txt, acid.txt
>
>
> TestAcidGuarantee has a test whereby it attempts to read a number of columns from a row, and every so often the first column of N is different, when it should be the same.  This is a bug deep inside the scanner whereby the first peek() of a row is done at time T then the rest of the read is done at T+1 after a flush, thus the memstoreTS data is lost, and previously 'uncommitted' data becomes committed and flushed to disk.
> One possible solution is to introduce the memstoreTS (or similarly equivalent value) to the HFile thus allowing us to preserve read consistency past flushes.  Another solution involves fixing the scanners so that peek() is not destructive (and thus might return different things at different times alas).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira