Return-Path: 
 <issues-return-20834-apmail-hbase-issues-archive=hbase.apache.org@hbase.apache.org>
X-Original-To: apmail-hbase-issues-archive@www.apache.org
Delivered-To: apmail-hbase-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 463C69CEA
	for <apmail-hbase-issues-archive@www.apache.org>;
 Mon,  3 Oct 2011 15:05:01 +0000 (UTC)
Received: (qmail 88691 invoked by uid 500); 3 Oct 2011 15:05:01 -0000
Delivered-To: apmail-hbase-issues-archive@hbase.apache.org
Received: (qmail 88657 invoked by uid 500); 3 Oct 2011 15:05:01 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 88648 invoked by uid 99); 3 Oct 2011 15:05:01 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Oct 2011 15:05:01 +0000
X-ASF-Spam-Status: No, hits=-2000.5 required=5.0
	tests=ALL_TRUSTED,RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Oct 2011 15:04:55 +0000
Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116])
	by hel.zones.apache.org (Postfix) with ESMTP id 175E22A6EBC
	for <issues@hbase.apache.org>; Mon,  3 Oct 2011 15:04:34 +0000 (UTC)
Date: Mon, 3 Oct 2011 15:04:34 +0000 (UTC)
From: "ramkrishna.s.vasudevan (Commented) (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <788026424.3286.1317654274097.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <818390486.9380.1316886566191.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-4479) TestMasterFailover failure in
 Hbase-0.92#17
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
X-Virus-Checked: Checked by ClamAV on apache.org


    [ https://issues.apache.org/jira/browse/HBASE-4479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119347#comment-13119347 ] 

ramkrishna.s.vasudevan commented on HBASE-4479:
-----------------------------------------------

@Ted
Testcases are running now.  Will submit the patch once done. 
The fix is just a one line fix.  Correct me if this will not be ok.
In assignAllUserRegions() just
{code}
List<ServerName> servers = serverManager.getOnlineServersList();
+ if(servers.size() == 0) return;
{code}

                
> TestMasterFailover failure in Hbase-0.92#17
> -------------------------------------------
>
>                 Key: HBASE-4479
>                 URL: https://issues.apache.org/jira/browse/HBASE-4479
>             Project: HBase
>          Issue Type: Bug
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Minor
>
> When the master restarted it was not able to get any servers online and the restart was a clean restart.
> Hence there were no regions to assign.
> Hence the retainAssignment tries to get one of the regions and uses RANDOM.getInt(size).  Here size is 0.
> So ideally 0 is not accepted here.  Hence we have got an exception making the master not to come up and the test case timeout.
> Though we need to see if really no regions was expected when the master came up, but this JIRA's intent is to deal such scenario where the size can be 0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira