Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 14 Oct 2011 03:42:13 +0000 (UTC)
From: "jiraposter@reviews.apache.org (Commented) (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <520853516.12631.1318563733343.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <360423970.7648.1318470551827.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-4585) Avoid seek operation when current
 kv is deleted
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-4585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127258#comment-13127258 ] 

jiraposter@reviews.apache.org commented on HBASE-4585:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2384/#review2578
-----------------------------------------------------------

Ship it!


I've been mucking in that code for a bit and was thinking about something along similar lines. You beat me to it :)

- Lars


On 2011-10-13 22:18:51, Liyin wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2384/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-10-13 22:18:51)
bq.  
bq.  
bq.  Review request for hbase, Dhruba Borthakur, Michael Stack, Jonathan Gray, Mikhail Bautin, Kannan Muthukkaruppan, Jerry Chen, Karthik Ranganathan, and Nicolas Spiegelberg.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  When the current kv is deleted during the matching in the ScanQueryMatcher, currently the matcher will return skip and continue to seek.
bq.  Actually, if the current kv is deleted because of family deleted or column deleted, the matcher should seek to next col.
bq.  If the current kv is deleted because of version deleted, the matcher should just return skip.
bq.  
bq.  I will submit another patch against apache-trunk later.
bq.  
bq.  
bq.  This addresses bug HBASE-4585.
bq.      https://issues.apache.org/jira/browse/HBASE-4585
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    src/test/java/org/apache/hadoop/hbase/regionserver/TestScanDeleteTracker.java afb3fcc 
bq.    src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksRead.java e8ac027 
bq.    src/main/java/org/apache/hadoop/hbase/regionserver/ScanQueryMatcher.java a1d7de5 
bq.    src/main/java/org/apache/hadoop/hbase/regionserver/DeleteTracker.java b425bf2 
bq.    src/main/java/org/apache/hadoop/hbase/regionserver/ScanDeleteTracker.java 1a891a6 
bq.  
bq.  Diff: https://reviews.apache.org/r/2384/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Running all the unit tests.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Liyin
bq.  
bq.


> Avoid seek operation when current kv is deleted
> -----------------------------------------------
>
>                 Key: HBASE-4585
>                 URL: https://issues.apache.org/jira/browse/HBASE-4585
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Liyin Tang
>            Assignee: Liyin Tang
>
> When the current kv is deleted during the matching in the ScanQueryMatcher, currently the matcher will return skip and continue to seek.
> Actually, if the current kv is deleted because of family deleted or column deleted, the matcher should seek to next col.
> If the current kv is deleted because of version deleted, the matcher should just return skip.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira