Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0A94D71DC for ; Wed, 5 Oct 2011 01:27:59 +0000 (UTC) Received: (qmail 37178 invoked by uid 500); 5 Oct 2011 01:27:58 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 37153 invoked by uid 500); 5 Oct 2011 01:27:58 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 37145 invoked by uid 99); 5 Oct 2011 01:27:58 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Oct 2011 01:27:58 +0000 X-ASF-Spam-Status: No, hits=-2000.5 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Oct 2011 01:27:56 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 30C2F2A916E for ; Wed, 5 Oct 2011 01:27:35 +0000 (UTC) Date: Wed, 5 Oct 2011 01:27:35 +0000 (UTC) From: "Jonathan Gray (Commented) (JIRA)" To: issues@hbase.apache.org Message-ID: <27969934.10312.1317778055201.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <927471525.36309.1316205128992.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HBASE-4422) Move block cache parameters and references into single CacheConf class MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HBASE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13120637#comment-13120637 ] Jonathan Gray commented on HBASE-4422: -------------------------------------- Yeah, if this goes to trunk but not 92 then begins the fun of rebasing patches for each because it changes so many constructors in/around HFile. > Move block cache parameters and references into single CacheConf class > ---------------------------------------------------------------------- > > Key: HBASE-4422 > URL: https://issues.apache.org/jira/browse/HBASE-4422 > Project: HBase > Issue Type: Improvement > Components: io > Reporter: Jonathan Gray > Assignee: Jonathan Gray > Fix For: 0.92.0 > > Attachments: CacheConfig92-v8.patch > > > From StoreFile down to HFile, we currently use a boolean argument for each of the various block cache configuration parameters that exist. The number of parameters is going to continue to increase as we look at compressed cache, delta encoding, and more specific L1/L2 configuration. Every new config currently requires changing many constructors because it introduces a new boolean. > We should move everything into a single class so that modifications are much less disruptive. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira