Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Sat, 1 Oct 2011 05:18:45 +0000 (UTC)
From: "stack (Commented) (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <2136843695.14534.1317446325806.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1095442025.9675.1317338265586.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-4519) 25s sleep when expiring sessions in
 tests
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-4519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118674#comment-13118674 ] 

stack commented on HBASE-4519:
------------------------------

I tried it and these failed:

{code}
Failed tests:   testOnlineChangeTableSchema(org.apache.hadoop.hbase.client.TestAdmin)
  testForceSplitMultiFamily(org.apache.hadoop.hbase.client.TestAdmin): expected:<2> but was:<1>
  testMergeTool(org.apache.hadoop.hbase.util.TestMergeTool): 'merging regions 0 and 1' failed with errCode -1
  testResetZooKeeperSession(org.apache.hadoop.hbase.replication.TestReplicationPeer): ReplicationPeer ZooKeeper session was not properly expired.
{code}

The TestReplicationPeer might be related.
                
> 25s sleep when expiring sessions in tests
> -----------------------------------------
>
>                 Key: HBASE-4519
>                 URL: https://issues.apache.org/jira/browse/HBASE-4519
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.4
>            Reporter: Jean-Daniel Cryans
>             Fix For: 0.92.0
>
>
> There's a hardcoded 25 seconds sleep in HBaseTestingUtility.expireSession: 
> {code}
> int sessionTimeout = 5 * 1000; // 5 seconds
> ...
> final long sleep = sessionTimeout * 5L;
> LOG.info("ZK Closed Session 0x" + Long.toHexString(sessionID) +
>   "; sleeping=" + sleep);
> Thread.sleep(sleep);
> {code}
> I'm pretty sure this can be lowered at lot, and it would speed up a couple of tests. The only thing I'm afraid of is if this was made to accomodate flaky tests.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira