Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 13 Oct 2011 21:33:13 +0000 (UTC)
From: "jiraposter@reviews.apache.org (Commented) (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <1581805033.11171.1318541593379.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <360423970.7648.1318470551827.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-4585) Avoid seek operation when current
 kv is deleted
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-4585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126961#comment-13126961 ] 

jiraposter@reviews.apache.org commented on HBASE-4585:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2384/
-----------------------------------------------------------

(Updated 2011-10-13 21:33:17.853931)


Review request for hbase, Michael Stack, Jonathan Gray, Mikhail Bautin, Kannan Muthukkaruppan, and Nicolas Spiegelberg.


Changes
-------

Address Mikhail's comments.


Summary
-------

When the current kv is deleted during the matching in the ScanQueryMatcher, currently the matcher will return skip and continue to seek.
Actually, if the current kv is deleted because of family deleted or column deleted, the matcher should seek to next col.
If the current kv is deleted because of version deleted, the matcher should just return skip.

I will submit another patch against apache-trunk later.


This addresses bug HBASE-4585.
    https://issues.apache.org/jira/browse/HBASE-4585


Diffs (updated)
-----

  src/test/java/org/apache/hadoop/hbase/regionserver/TestScanDeleteTracker.java afb3fcc 
  src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksRead.java e8ac027 
  src/main/java/org/apache/hadoop/hbase/regionserver/ScanQueryMatcher.java a1d7de5 
  src/main/java/org/apache/hadoop/hbase/regionserver/DeleteTracker.java b425bf2 
  src/main/java/org/apache/hadoop/hbase/regionserver/ScanDeleteTracker.java 1a891a6 

Diff: https://reviews.apache.org/r/2384/diff


Testing
-------

Running all the unit tests.


Thanks,

Liyin


> Avoid seek operation when current kv is deleted
> -----------------------------------------------
>
>                 Key: HBASE-4585
>                 URL: https://issues.apache.org/jira/browse/HBASE-4585
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Liyin Tang
>            Assignee: Liyin Tang
>
> When the current kv is deleted during the matching in the ScanQueryMatcher, currently the matcher will return skip and continue to seek.
> Actually, if the current kv is deleted because of family deleted or column deleted, the matcher should seek to next col.
> If the current kv is deleted because of version deleted, the matcher should just return skip.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira