Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 27 Oct 2011 20:22:36 +0000 (UTC)
From: "jiraposter@reviews.apache.org (Commented) (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <1573950410.26573.1319746956056.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1252214639.26213.1319745032232.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-4689) [89-fb] Make the table level
 metrics work with rpc* metrics
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-4689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137490#comment-13137490 ] 

jiraposter@reviews.apache.org commented on HBASE-4689:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2587/
-----------------------------------------------------------

(Updated 2011-10-27 20:23:31.651831)


Review request for hbase, Mikhail Bautin, Pritam Damania, Prakash Khemani, Amitanand Aiyer, Kannan Muthukkaruppan, Jerry Chen, Karthik Ranganathan, and Nicolas Spiegelberg.


Summary
-------

In r1182034, the per table/cf for rpc* metrics has a bug. It will only show cf level metrics even though we enabled the per table level metrics.
Fix this bug here.


This addresses bug HBASE-4689.
    https://issues.apache.org/jira/browse/HBASE-4689


Diffs
-----

  src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 6c821c0 
  src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java 8776ffe 
  src/test/java/org/apache/hadoop/hbase/regionserver/metrics/TestSchemaMetrics.java c03532a 

Diff: https://reviews.apache.org/r/2587/diff


Testing (updated)
-------

Passed all the unit tests and tested the rpc metrics in the dev cluster


Thanks,

Liyin


> [89-fb] Make the table level metrics work with rpc* metrics
> -----------------------------------------------------------
>
>                 Key: HBASE-4689
>                 URL: https://issues.apache.org/jira/browse/HBASE-4689
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: 0.89.20100924
>            Reporter: Liyin Tang
>            Assignee: Liyin Tang
>         Attachments: hbase-4689.patch
>
>
> In r1182034, the per table/cf for rpc* metrics has a bug. It will only show cf level metrics even though we enabled the per table level metrics.
> Fix this bug here.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira